1396022 - Update in-tree docs regarding CoT and image hashes and whatnot

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1396022: combine docker docs, talk about hsahes;

Review commit: https://reviewboard.mozilla.org/r/175494/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175494/

Comment 2

[Greg Arndt [:garndt]]

Comment on attachment 8903732 [details]
Bug 1396022: combine docker docs, talk about hsahes;

https://reviewboard.mozilla.org/r/175494/#review181264

::: taskcluster/docs/docker-images.rst:34
(Diff revision 1)
> +
> +Images can be uploaded as a task artifact, [indexed](#task-image-index-namespace) under
> +a given namespace, and used in other tasks by referencing the task ID.
> +
> +Important to note, these images do not require building and pushing to a docker registry, and are
> +build per push (if necessary) and uploaded as task artifacts.

s/build/built/

::: taskcluster/docs/docker-images.rst:107
(Diff revision 1)
> +
> +    image: taskcluster/decision:0.1.10@sha256:c5451ee6c655b3d97d4baa3b0e29a5115f23e0991d4f7f36d2a8f793076d6854
> +
> +Each image has a repo digest, an image hash, and a version. The repo digest is
> +stored in the ``HASH`` file in the image directory  and used to refer to the
> +image as above The version is in ``VERSION``.  The image hash is used in

'above. The version..."

::: taskcluster/docs/docker-images.rst:127
(Diff revision 1)
> +There are several hashes involved in this process:
> +
> + * Image Hash -- the long version of the image ID; can be seen with
> +   ``docker images --no-trunc`` or in the ``Id`` field in ``docker inspect``.
> +
> + * Repo Digest -- hash of the image manifest; seen when running ``docker

is this the hash of the image manifest? I could be completely mistaken, but I thought the image hash/id was a hash of the image manifest, but the repo digest was the actual hash of the uncompressed contents of each layer.

Comment 3

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 8eeaa1abab42 -d 1bf2e9fab3ac: rebasing 418027:8eeaa1abab42 "Bug 1396022: combine docker docs, talk about hsahes; r=garndt" (tip)
local [dest] changed taskcluster/docker/README.md which other [source] deleted
use (c)hanged version, (d)elete, or leave (u)nresolved? u
merging taskcluster/docs/docker-images.rst
warning: conflicts while merging taskcluster/docs/docker-images.rst! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8903732 [details]
Bug 1396022: combine docker docs, talk about hsahes;

https://reviewboard.mozilla.org/r/175494/#review181272

::: taskcluster/docs/docker-images.rst:127
(Diff revision 1)
> +There are several hashes involved in this process:
> +
> + * Image Hash -- the long version of the image ID; can be seen with
> +   ``docker images --no-trunc`` or in the ``Id`` field in ``docker inspect``.
> +
> + * Repo Digest -- hash of the image manifest; seen when running ``docker

I think it's a hash of the manifest which *contains* hashes of the layers.  At least, that was how I read the vague docs..

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8903732 [details]
Bug 1396022: combine docker docs, talk about hsahes;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/175494/diff/1-2/

Comment 6

[Mozilla Autoland]

hg error in cmd: hg push -r . -f try: pushing to ssh://hg.mozilla.org/try
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 2 changesets with 1 changes to 1 files (+1 heads)
remote: 
remote: ***************************** ERROR ******************************
remote: Your try syntax would not trigger any jobs. Either specify a build
remote: with '-p' or an arbitrary job with '-j'. If you intended to push
remote: without triggering any jobs, omit the try syntax completely.
remote: 
remote: For more information, see https://wiki.mozilla.org/Try.
remote: ******************************************************************
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.c_try_warning hook failed
abort: push failed on remote

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/237ae9435645
combine docker docs, talk about hsahes; r=garndt

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/237ae9435645