1396025 - Write a comment to explain the difference between eBBoxIncludeFill and eBBoxIncludeFillGeometry

Status: RESOLVED FIXED

(Core :: SVG, enhancement)

Comment 1

[u459114]

Attachment: Bug 1396025 - Write a comment to explain the difference between eBBoxIncludeFill/eBBoxIncludeStroke and eBBoxIncludeFillGeometry/eBBoxIncludeStrokeGeometry.

Review commit: https://reviewboard.mozilla.org/r/175466/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175466/

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 8903688 [details]
Bug 1396025 - Write a comment to explain the difference between eBBoxIncludeFill/eBBoxIncludeStroke and eBBoxIncludeFillGeometry/eBBoxIncludeStrokeGeometry.

https://reviewboard.mozilla.org/r/175466/#review181498

Nice, thank you.

::: layout/svg/nsSVGUtils.h:393
(Diff revision 1)
>                                          uint32_t aFlags);
>  
>    enum BBoxFlags {
>      eBBoxIncludeFill           = 1 << 0,
> +    // Include the geometry of the fill even when the fill does not
> +    // actually render(e.g. when fill="none" or fill-opacity="0")

Space after "render", please.

::: layout/svg/nsSVGUtils.h:397
(Diff revision 1)
> +    // Include the geometry of the fill even when the fill does not
> +    // actually render(e.g. when fill="none" or fill-opacity="0")
>      eBBoxIncludeFillGeometry   = 1 << 1,
>      eBBoxIncludeStroke         = 1 << 2,
> +    // Include the geometry of the stroke even when the stroke does not
> +    // actually render(e.g. when stroke="none" or stroke-opacity="0")

Space after "render", please.

Comment 3

[u459114]

Comment on attachment 8903688 [details]
Bug 1396025 - Write a comment to explain the difference between eBBoxIncludeFill/eBBoxIncludeStroke and eBBoxIncludeFillGeometry/eBBoxIncludeStrokeGeometry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/175466/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66954c786c3a
Write a comment to explain the difference between eBBoxIncludeFill/eBBoxIncludeStroke and eBBoxIncludeFillGeometry/eBBoxIncludeStrokeGeometry. r=jwatt

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/66954c786c3a