Closed
Bug 1396025
Opened 7 years ago
Closed 7 years ago
Write a comment to explain the difference between eBBoxIncludeFill and eBBoxIncludeFillGeometry
Categories
(Core :: SVG, enhancement)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: u459114, Assigned: u459114)
Details
Attachments
(1 file)
No description provided.
Comment hidden (mozreview-request) |
Attachment #8903688 -
Flags: review?(jwatt)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8903688 [details] Bug 1396025 - Write a comment to explain the difference between eBBoxIncludeFill/eBBoxIncludeStroke and eBBoxIncludeFillGeometry/eBBoxIncludeStrokeGeometry. https://reviewboard.mozilla.org/r/175466/#review181498 Nice, thank you. ::: layout/svg/nsSVGUtils.h:393 (Diff revision 1) > uint32_t aFlags); > > enum BBoxFlags { > eBBoxIncludeFill = 1 << 0, > + // Include the geometry of the fill even when the fill does not > + // actually render(e.g. when fill="none" or fill-opacity="0") Space after "render", please. ::: layout/svg/nsSVGUtils.h:397 (Diff revision 1) > + // Include the geometry of the fill even when the fill does not > + // actually render(e.g. when fill="none" or fill-opacity="0") > eBBoxIncludeFillGeometry = 1 << 1, > eBBoxIncludeStroke = 1 << 2, > + // Include the geometry of the stroke even when the stroke does not > + // actually render(e.g. when stroke="none" or stroke-opacity="0") Space after "render", please.
Attachment #8903688 -
Flags: review?(jwatt) → review+
Comment hidden (mozreview-request) |
Pushed by cku@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/66954c786c3a Write a comment to explain the difference between eBBoxIncludeFill/eBBoxIncludeStroke and eBBoxIncludeFillGeometry/eBBoxIncludeStrokeGeometry. r=jwatt
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/66954c786c3a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•