Closed
Bug 1396031
Opened 7 years ago
Closed 6 years ago
Create browser.menus.show(contextType, parameters, contextParameters);
Categories
(WebExtensions :: General, enhancement, P3)
WebExtensions
General
Tracking
(firefox57 wontfix)
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
firefox57 | --- | wontfix |
People
(Reporter: ntim, Unassigned)
References
Details
(Whiteboard: [design-decision-approved][contextMenus][ntim-backlog])
It would be nice to have a method that shows built-in context menus.
What I would suggest is the following API:
browser.menus.show(contextType, { location: "browser_action/page_action/sidebar_action/webcontent", x: ..., y: ..., }, contextParameters);
contextType corresponds to one of the following ContextTypes: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/contextMenus/ContextType
x and y are relative to the location.
contextParameters depends on the contextType chosen, for example, the tab context menu would take a WE tabId.
Use cases:
- Showing the tab context menu for sidebar tabs
browser.menus.show("tab", { location: "sidebar_action", x: ..., y: ... }, tabId);
You can reimplement the context menu from scratch, but that would have the following drawbacks: extensions can't integrate, the sidebar tabs extension will be out of date with firefox context menu changes, etc.
- Showing the bookmarks context menu for an advanced bookmarks manager
- UI tour for context menu items provided by an extension
An alternative approach has been suggested for the first use case: bug 1280347
Reporter | ||
Comment 1•7 years ago
|
||
Another alternative for the first use case would be having a browser.tabstrip namespace with 2 features:
- showing or hiding the tabstrip (bug 1332447)
browser.tabstrip.hide/show()
- showing the tabstrip context menu
browser.tabstrip.showContextMenu(tabId, { location, x, y });
Updated•7 years ago
|
Whiteboard: [design-decision-needed]
Comment 2•7 years ago
|
||
This is very important for addon authors planning to migrate their addon including custom tab UI, from XUL to WebExtensions. Actually, my "Tree Style Tab" addon is already rebuilt on WebExtensions APIs mostly and only context menu is the largest one left as unmigrated feature...
(FYI, unsigned development build: https://piro.sakura.ne.jp/xul/xpi/nightly/treestyletab-we.xpi )
Updated•7 years ago
|
status-firefox57:
--- → wontfix
Priority: -- → P3
Whiteboard: [design-decision-needed] → [design-decision-needed][contextMenus]
Comment 3•7 years ago
|
||
This bug as approved at the design decision triage meeting on January 23, 2018.
Meeting notes can be found here: https://docs.google.com/document/d/1Mc0h5OVd30WBjCORssdifZRXYQrk6WcTqX1cw6ADO9k/edit#
Whiteboard: [design-decision-needed][contextMenus] → [design-decision-approved][contextMenus]
Reporter | ||
Updated•7 years ago
|
Whiteboard: [design-decision-approved][contextMenus] → [design-decision-approved][contextMenus][ntim-backlog]
Updated•6 years ago
|
Product: Toolkit → WebExtensions
Comment 4•6 years ago
|
||
We don't want extensions to open arbitrary menus without user interaction.
We do want to allow extensions to be able to develop custom tab/bookmark managers.
I'm going to mark this as WONTFIX because this specific API implementation suggestion will not be followed.
Instead, I'm going to implement the ability to specify a custom context when an extension menu is opened, in bug 1280347.
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•