Closed
Bug 1396037
Opened 7 years ago
Closed 7 years ago
Use the new photon styles for the body, sidebar and toolbar background colors
Categories
(DevTools :: General, enhancement, P3)
DevTools
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
2.87 KB,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
2.40 KB,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•7 years ago
|
Blocks: devtools-visual
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8903985 -
Flags: review?(pbrosset)
Assignee | ||
Updated•7 years ago
|
Summary: Use the new photon styles for the toolbar background colors → Use the new photon styles for the body, sidebar and toolbar background colors
Assignee | ||
Comment 2•7 years ago
|
||
Light Theme body background-color: white toolbar/header background-color: --grey-10 Dark Theme body background-color: --grey-80 toolbar/header background-color: --grey-90
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8903985 -
Attachment is obsolete: true
Attachment #8903985 -
Flags: review?(pbrosset)
Attachment #8903986 -
Flags: review?(pbrosset)
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8903987 -
Flags: review?(pbrosset)
Updated•7 years ago
|
Attachment #8903986 -
Flags: review?(pbrosset) → review+
Updated•7 years ago
|
Attachment #8903987 -
Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e77976cfbab0 Part 1: Use the new photon styles for the body, sidebar and toolbar background colors. r=pbro https://hg.mozilla.org/integration/mozilla-inbound/rev/67055f747a43 Part 2: Use the photon border and background colors in the breadcrumbs. r=pbro
Comment 6•7 years ago
|
||
Comment on attachment 8903987 [details] [diff] [review] Part 2: Use the photon border and background colors in the breadcrumbs [1.0] Review of attachment 8903987 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/themes/inspector.css @@ -125,5 @@ > border-bottom-width: 0px; > border-top-width: 1px; > - border-top-color: var(--breadcrumbs-border-color); > - /* Bug 1262668 - Use the same background as the body so the breadcrumbs toolbar doesn't > - get mistaken as a splitter */ Is this not an issue anymore ?
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e77976cfbab0 https://hg.mozilla.org/mozilla-central/rev/67055f747a43
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Assignee | ||
Comment 8•7 years ago
|
||
(In reply to Tim Nguyen :ntim from comment #6) > Comment on attachment 8903987 [details] [diff] [review] > Part 2: Use the photon border and background colors in the breadcrumbs [1.0] > > Review of attachment 8903987 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: devtools/client/themes/inspector.css > @@ -125,5 @@ > > border-bottom-width: 0px; > > border-top-width: 1px; > > - border-top-color: var(--breadcrumbs-border-color); > > - /* Bug 1262668 - Use the same background as the body so the breadcrumbs toolbar doesn't > > - get mistaken as a splitter */ > > Is this not an issue anymore ? Hi Tim, you bring up a good point. I was mostly concerned with landing what I saw in the mockups. I will bring this up with Victoria.
Flags: needinfo?(gl)
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(gl)
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•