From Bugzilla Helper: User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:0.9.9+) Gecko/20020422 BuildID: 2002042203 The title of the bookmarks window is "Bookmarks for default". Every user will have his own "default" profile, and rarely any other, so there's no reason to tell me these are bookmarks "for default". Reproducible: Always Steps to Reproduce: 1. Start Mozilla 2. Choose Bookmarks -> Manage Bookmarks... Actual Results: The window title is "Bookmarks for default". Expected Results: The title chould just be "Bookmarks". If there are multiple profiles, you could then add "... for XYZ". If there is exactly one profile named "default", though, it seems silly.
16 years ago
taking, patch will follow
Created attachment 81504 [details] [diff] [review] patch v1.0 While at was around, I've done a bit of clean-up. Please, r=, sr=
Created attachment 81672 [details] [diff] [review] patch v1.1 Use of const instead of var per biesi request
Comment on attachment 81672 [details] [diff] [review] patch v1.1 r=biesi
What if the single profile isn't called default? (i.e. I've removed all my profiles but "Ben Goodger") Can't you check for the string that's used by the profile code as the default name instead?
Created attachment 84300 [details] [diff] [review] Patch v1.2 Ben, sure. ccarlen confirmed me that the default profile name is not localizable. On windows, it's 'Default' and on the others: 'default'. I also change the dtd. With this patch, the title of the bookmark manager is 'Bookmark Manager' if and only if there is one profile named 'default' in low case.
Ben, feel free to check in the dtd change or not.
Comment on attachment 84300 [details] [diff] [review] Patch v1.2 you could do the |windowNode.setAttribute("title", titleString);| after the if r=biesi
Biesi: I can not do that since I do not modify the bookmark manager title in one case (#profile=1 and profile name != default).
Comment on attachment 84300 [details] [diff] [review] Patch v1.2 firstname.lastname@example.org