Closed
Bug 1396073
Opened 7 years ago
Closed 7 years ago
Make :-moz-devtools-highlighted available only in UA sheets, and remove :-moz-empty-except-children-with-localname.
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla58
People
(Reporter: emilio, Assigned: emilio)
References
Details
(Keywords: dev-doc-complete)
Attachments
(4 files)
In particular: :-moz-system-metric-except-children-with-localname :-moz-devtools-highlighted :-moz-styleeditor-transitioning Will send intent to unship in a second.
Assignee | ||
Comment 1•7 years ago
|
||
(In reply to Emilio Cobos Álvarez [:emilio] from comment #0) > In particular: > > :-moz-system-metric-except-children-with-localname Err, :-moz-empty-except-children-with-localname.
Assignee | ||
Comment 2•7 years ago
|
||
https://groups.google.com/forum/#!topic/mozilla.dev.platform/mVFD29YcVEc
Assignee: nobody → emilio
Updated•7 years ago
|
Keywords: dev-doc-needed,
site-compat
Assignee | ||
Comment 3•7 years ago
|
||
Per IRC discussion with Jryans this requires moving the lone user of :-moz-styleeditor-transitioning to a UA sheet, but there doesn't seem to be a particular reason this is not done that way.
Depends on: 1396099
Updated•7 years ago
|
Priority: -- → P3
Updated•7 years ago
|
status-firefox55:
--- → wontfix
status-firefox56:
--- → wontfix
status-firefox57:
--- → affected
status-firefox-esr52:
--- → wontfix
Assignee | ||
Comment 4•7 years ago
|
||
I'll repurpose bug 1396099 to hide :-moz-styleeditor-transitioning, let's take care of the others now.
No longer depends on: 1396099
Summary: Avoid exposing various other pseudo-classes to content documents. → Make :-moz-devtools-highlighted available only in UA sheets, and remove :-moz-empty-except-children-with-localname.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8912710 -
Flags: review?(cam) → review?(xidorn+moz)
Attachment #8912711 -
Flags: review?(cam) → review?(xidorn+moz)
Attachment #8912712 -
Flags: review?(cam) → review?(xidorn+moz)
Attachment #8912713 -
Flags: review?(cam) → review?(xidorn+moz)
Comment 13•7 years ago
|
||
I'm out today but Xidorn can review this.
Comment 14•7 years ago
|
||
mozreview-review |
Comment on attachment 8912710 [details] Bug 1396073: Hide :-moz-devtools-highlighted from anywhere but UA sheets. https://reviewboard.mozilla.org/r/184040/#review189496
Attachment #8912710 -
Flags: review?(xidorn+moz) → review+
Comment 15•7 years ago
|
||
mozreview-review |
Comment on attachment 8912711 [details] Bug 1396073: Remove :-moz-empty-except-children-with-local-name. https://reviewboard.mozilla.org/r/184042/#review189498 ::: servo/components/style/gecko/non_ts_pseudo_class_list.rs:122 (Diff revision 2) > ("-moz-window-inactive", MozWindowInactive, mozWindowInactive, _, _), > ], > string: [ > // FIXME(emilio): Unship this for content docs (bug 1396066). > ("-moz-system-metric", MozSystemMetric, mozSystemMetric, _, _), > - // FIXME(emilio): Unship this for content docs (bug 1396073). > + mozEmptyExceptChildrenWithLocalname, _, PSEUDO_CLASS_ENABLED_IN_UA_SHEETS), It seems you left one line here.
Attachment #8912711 -
Flags: review?(xidorn+moz) → review+
Comment 16•7 years ago
|
||
mozreview-review |
Comment on attachment 8912712 [details] Bug 1396073: Remove some never matching rules for applet. https://reviewboard.mozilla.org/r/184044/#review189500
Attachment #8912712 -
Flags: review?(xidorn+moz) → review+
Comment 17•7 years ago
|
||
mozreview-review |
Comment on attachment 8912713 [details] Bug 1396073: Simplify and remove some more code. https://reviewboard.mozilla.org/r/184046/#review189504 ::: servo/components/style/gecko/non_ts_pseudo_class_list.rs (Diff revision 2) > ("-moz-window-inactive", MozWindowInactive, mozWindowInactive, _, _), > ], > string: [ > // FIXME(emilio): Unship this for content docs (bug 1396066). > ("-moz-system-metric", MozSystemMetric, mozSystemMetric, _, _), > - mozEmptyExceptChildrenWithLocalname, _, PSEUDO_CLASS_ENABLED_IN_UA_SHEETS), This should be done in the second patch.
Attachment #8912713 -
Flags: review?(xidorn+moz) → review+
Comment 18•7 years ago
|
||
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/autoland/rev/69d30bc2d048 Hide :-moz-devtools-highlighted from anywhere but UA sheets. r=xidorn https://hg.mozilla.org/integration/autoland/rev/736aac6f2c4d Remove :-moz-empty-except-children-with-local-name. r=xidorn https://hg.mozilla.org/integration/autoland/rev/ec77f71780ff Remove some never matching rules for applet. r=xidorn https://hg.mozilla.org/integration/autoland/rev/b55bc9d096ef Simplify and remove some more code. r=xidorn
Comment 19•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/69d30bc2d048 https://hg.mozilla.org/mozilla-central/rev/736aac6f2c4d https://hg.mozilla.org/mozilla-central/rev/ec77f71780ff https://hg.mozilla.org/mozilla-central/rev/b55bc9d096ef
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Updated•7 years ago
|
Keywords: site-compat
Comment 20•7 years ago
|
||
We shipped several releases with this. We should let it ride the train.
Comment 21•7 years ago
|
||
We never bothered to document either of these in the first place, and since neither are available to the web, I'm not going to bother mentioning them on MDN.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•