1396073 - Make :-moz-devtools-highlighted available only in UA sheets, and remove :-moz-empty-except-children-with-localname.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

In particular:

 :-moz-system-metric-except-children-with-localname
 :-moz-devtools-highlighted
 :-moz-styleeditor-transitioning

Will send intent to unship in a second.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #0)
> In particular:
> 
>  :-moz-system-metric-except-children-with-localname

Err,  :-moz-empty-except-children-with-localname.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

https://groups.google.com/forum/#!topic/mozilla.dev.platform/mVFD29YcVEc

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Per IRC discussion with Jryans this requires moving the lone user of :-moz-styleeditor-transitioning to a UA sheet, but there doesn't seem to be a particular reason this is not done that way.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I'll repurpose bug 1396099 to hide :-moz-styleeditor-transitioning, let's take care of the others now.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1396073: Hide :-moz-devtools-highlighted from anywhere but UA sheets.

It's always used from a UA sheet already.

Review commit: https://reviewboard.mozilla.org/r/184040/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184040/

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1396073: Remove :-moz-empty-except-children-with-local-name.

<applet> is not a thing anymore, and that selector in our UA sheet will never
match anyway, since an <applet> element will never have the BROKEN state.

Review commit: https://reviewboard.mozilla.org/r/184042/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184042/

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1396073: Remove some never matching rules for applet.

Review commit: https://reviewboard.mozilla.org/r/184044/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184044/

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1396073: Simplify and remove some more code.

Review commit: https://reviewboard.mozilla.org/r/184046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184046/

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8912710 [details]
Bug 1396073: Hide :-moz-devtools-highlighted from anywhere but UA sheets.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184040/diff/1-2/

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8912711 [details]
Bug 1396073: Remove :-moz-empty-except-children-with-local-name.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184042/diff/1-2/

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8912712 [details]
Bug 1396073: Remove some never matching rules for applet.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184044/diff/1-2/

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8912713 [details]
Bug 1396073: Simplify and remove some more code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184046/diff/1-2/

Comment 13

[Cameron McCormack (:heycam)]

I'm out today but Xidorn can review this.

Comment 14

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8912710 [details]
Bug 1396073: Hide :-moz-devtools-highlighted from anywhere but UA sheets.

https://reviewboard.mozilla.org/r/184040/#review189496

Comment 15

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8912711 [details]
Bug 1396073: Remove :-moz-empty-except-children-with-local-name.

https://reviewboard.mozilla.org/r/184042/#review189498

::: servo/components/style/gecko/non_ts_pseudo_class_list.rs:122
(Diff revision 2)
>                  ("-moz-window-inactive", MozWindowInactive, mozWindowInactive, _, _),
>              ],
>              string: [
>                  // FIXME(emilio): Unship this for content docs (bug 1396066).
>                  ("-moz-system-metric", MozSystemMetric, mozSystemMetric, _, _),
> -                // FIXME(emilio): Unship this for content docs (bug 1396073).
> +                 mozEmptyExceptChildrenWithLocalname, _, PSEUDO_CLASS_ENABLED_IN_UA_SHEETS),

It seems you left one line here.

Comment 16

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8912712 [details]
Bug 1396073: Remove some never matching rules for applet.

https://reviewboard.mozilla.org/r/184044/#review189500

Comment 17

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8912713 [details]
Bug 1396073: Simplify and remove some more code.

https://reviewboard.mozilla.org/r/184046/#review189504

::: servo/components/style/gecko/non_ts_pseudo_class_list.rs
(Diff revision 2)
>                  ("-moz-window-inactive", MozWindowInactive, mozWindowInactive, _, _),
>              ],
>              string: [
>                  // FIXME(emilio): Unship this for content docs (bug 1396066).
>                  ("-moz-system-metric", MozSystemMetric, mozSystemMetric, _, _),
> -                 mozEmptyExceptChildrenWithLocalname, _, PSEUDO_CLASS_ENABLED_IN_UA_SHEETS),

This should be done in the second patch.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69d30bc2d048
Hide :-moz-devtools-highlighted from anywhere but UA sheets. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/736aac6f2c4d
Remove :-moz-empty-except-children-with-local-name. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/ec77f71780ff
Remove some never matching rules for applet. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/b55bc9d096ef
Simplify and remove some more code. r=xidorn

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/69d30bc2d048
https://hg.mozilla.org/mozilla-central/rev/736aac6f2c4d
https://hg.mozilla.org/mozilla-central/rev/ec77f71780ff
https://hg.mozilla.org/mozilla-central/rev/b55bc9d096ef

Comment 20

[Sylvestre Ledru [:Sylvestre]]

We shipped several releases with this. We should let it ride the train.

Comment 21

[Chris Mills [:cmills]]

We never bothered to document either of these in the first place, and since neither are available to the web, I'm not going to bother mentioning them on MDN.