1396086 - Add support for compressing PDB/DLL/EXE files with makecab server-side

Status: RESOLVED WONTFIX

(Tecken :: Upload, enhancement, P3)

Description

[(not currently active) Ted Mielczarek]

Currently the Firefox build system runs makecab to compress PDB, DLL, and EXE files before putting them in the symbols.zip file to upload to the symbol server:
https://github.com/luser/rust-makecab

This takes time during the build. Since we're putting them in a zip file anyway (which has compression), the zip file would probably be about the same size if we *didn't* compress them, and then Tecken could compress them with makecab before storing them in s3, like how it already gzip-compresses .sym files.

It's probably worth testing what impact this would have on Firefox build times before implementing anything in Tecken, because it's possible it might not be enough of a build-time win to be worth the hassle.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Moving Tecken service bugs to Tecken component.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Moving bugs to Tecken product.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'm going to make this a P3 for now. If nothing has happened here or in the bug that depends on this one by the time I next triage, then I'll close it out.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Tagging glandium to figure out what impact not running makecab has on the task that uploads symbols (I think that's where makecab is run).

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

We talked in Matrix and this feels like a nice-to-have, but there isn't a compelling reason like "speeds up build times!" to do the work and there are some possible consequences for Tecken.

I'm pretty sure it is possible to add running makecab for incoming non-debug-symbols files in Tecken, but we really need to rewrite the upload processing first. That's covered in bug #1652835.

I'm on the fence about whether to WONTFIX this because it's nice-to-have, but not necessary or whether to leave it sitting around. So for now I'm going to have it depend on bug #1652835 and let it sit.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

It's been a while since I looked at this. I'm going to mark it WONTFIX.