1396093 - stylo: Fix layout/reftests/bugs/485012-1.html after bug 1354989.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

See bug 1354989 comment 34.

Let's get it fixed in this bug.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1396093 - Add a missing leading zero byte to a test case that uses UTF-16BE.

Review commit: https://reviewboard.mozilla.org/r/176032/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176032/

Comment 2

[Henri Sivonen (:hsivonen)]

Looks like the test input lacked one zero byte. I don't have an explanation for why this worked with the old style system.

Comment 3

[Henri Sivonen (:hsivonen)]

Comment on attachment 8904258 [details]
Bug 1396093 - Add a missing leading zero byte to a test case that uses UTF-16BE.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/176032/diff/1-2/

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8904258 [details]
Bug 1396093 - Add a missing leading zero byte to a test case that uses UTF-16BE.

https://reviewboard.mozilla.org/r/176032/#review181084

r=me, but can you specify on the commit message that the test worked on gecko because the string was truncated instead of decoding a replacement character?

Comment 5

[Henri Sivonen (:hsivonen)]

Comment on attachment 8904258 [details]
Bug 1396093 - Add a missing leading zero byte to a test case that uses UTF-16BE.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/176032/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c46043dc11c6
Add a missing leading zero byte to a test case that uses UTF-16BE. r=emilio

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c46043dc11c6