Closed
Bug 1396135
Opened 7 years ago
Closed 7 years ago
stylo: Fix stress-1.html test in layout/reftests/first-line/reftest.list
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | wontfix |
firefox57 | --- | fixed |
People
(Reporter: cpeterson, Assigned: xidorn)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
layout/reftests/first-line/reftest.list 16 skip-if(styloVsGecko) load stress-1.html # assertion test Why does this test fail only in styloVsGecko mode?
Reporter | ||
Updated•7 years ago
|
Blocks: stylo-reftest
status-firefox55:
--- → unaffected
status-firefox56:
--- → wontfix
status-firefox-esr52:
--- → unaffected
Reporter | ||
Updated•7 years ago
|
Priority: -- → P3
Comment 1•7 years ago
|
||
Removing "skip-if(styloVsGecko)" in that line and running "mach reftest layout/reftests/first-line --setpref=reftest.compareStyloToGecko=true" works for me. ("REFTEST INFO | Unexpected: 0", successful exit code.) Is the underlying problem fixed or am I missing something?
Flags: needinfo?(emilio)
Comment 2•7 years ago
|
||
That sounds likely, if a try run with the annotation removed passes, let's get it removed.
Flags: needinfo?(emilio)
Assignee | ||
Comment 3•7 years ago
|
||
Looks all good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c55fe1e9b7a14cedc81a252204c28d3cbb247cf
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8907474 [details] Bug 1396135 - Re-enable first-line/stress-1.html for styloVsGecko. https://reviewboard.mozilla.org/r/179168/#review184268
Attachment #8907474 -
Flags: review+
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a376f9a9cd53 Re-enable first-line/stress-1.html for styloVsGecko. r=xidorn
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a376f9a9cd53
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•6 years ago
|
Assignee: nobody → xidorn+moz
You need to log in
before you can comment on or make changes to this bug.
Description
•