stylo: Fix skipped and random-if tests in layout/reftests/forms/

RESOLVED FIXED in Firefox 57

Status

()

P2
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: cpeterson, Assigned: xidorn)

Tracking

(Blocks: 1 bug)

57 Branch
mozilla57
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 wontfix, firefox57 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

a year ago
+++ This bug was initially created as a clone of Bug #1396135 +++

layout/reftests/forms/input/number/reftest.list
39	fuzzy-if(skiaContent,2,5) needs-focus skip-if(styloVsGecko||stylo) == focus-handling.html focus-handling-ref.html

Why do we skip this test in both stylo and styloVsGecko mode?
(Reporter)

Comment 1

a year ago
Also, why is this test random-if styloVsGecko?

layout/reftests/forms/progress/reftest.list
5	random-if(styloVsGecko) == bar-pseudo-element.html bar-pseudo-element-ref.html
Summary: stylo: Fix focus-handling.html test in layout/reftests/forms/input/number/reftest.list → stylo: Fix skipped and random-if tests in layout/reftests/forms/
(Reporter)

Updated

a year ago
Blocks: 1396147
(Reporter)

Updated

a year ago
No longer blocks: 1396147
Priority: -- → P2
(Assignee)

Comment 2

a year ago
So it seems that bar-pseudo-element.html is fine, while focus-handling.html has high frequent intermittent: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7fe1bf6ccef121c287ba3099105625db1038d25b

Locally, I can reproduce the issue of focus-handling.html. It seems when the failure happens, the first input element get focus a second time, in which, the focus() call doesn't trigger refocusing to the second input element.

I have no idea why this would be stylo-specific. It seems to me that it happens to non-stylo as well, in a very low frequency (see bug 1284330 and bug 1126084), I suspect it is a timing issue which stylo happens to make more frequent. We can probably just workaround the test somehow.
(Assignee)

Updated

a year ago
Assignee: nobody → xidorn+moz
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 6

a year ago
mozreview-review
Comment on attachment 8904435 [details]
Bug 1396136 part 1 - Make forms/input/number/focus-handling.html more robust.

https://reviewboard.mozilla.org/r/176284/#review181502
Attachment #8904435 - Flags: review?(jwatt) → review+
(Assignee)

Comment 7

a year ago
mozreview-review
Comment on attachment 8904436 [details]
Bug 1396136 part 2 - Re-enable reftests in forms.

https://reviewboard.mozilla.org/r/176286/#review181526
Attachment #8904436 - Flags: review+

Comment 8

a year ago
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6a9c476a2db
part 1 - Make forms/input/number/focus-handling.html more robust. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/ffb160236c24
part 2 - Re-enable reftests in forms. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/f6a9c476a2db
https://hg.mozilla.org/mozilla-central/rev/ffb160236c24
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.