stylo: Fix skipped and random-if tests in layout/reftests/w3c-css/submitted

RESOLVED FIXED in Firefox 57

Status

()

defect
RESOLVED FIXED
2 years ago
9 months ago

People

(Reporter: cpeterson, Assigned: xidorn)

Tracking

(Blocks 1 bug)

57 Branch
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 wontfix, firefox57 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

2 years ago
> layout/reftests/w3c-css/submitted/images3/reftest.list
> 179	fails-if(!styloVsGecko&&!webrender) fuzzy-if(styloVsGecko,11,388) == object-position-png-002c.html object-position-png-002-ref.html # bug 1105150

This test appears to fail in both Stylo and Gecko. It only "passes" in styloVsGecko because they both fail. The annotation should probably be changed to `fails-if(!webrender)`.

> layout/reftests/forms/input/number/reftest.list
> 99	skip-if(stylo&&winWidget) == shape-outside-inset-027.html shape-outside-inset-027-ref.html

Why is this test skipped only for Stylo on Windows?
Reporter

Updated

2 years ago
No longer depends on: 1396136
Assignee

Comment 1

2 years ago
shape-outside-inset-027.html is in layout/reftests/w3c-css/submitted/shapes1

And it seems to me this test passes on Windows locally. I guess we can just enable it.
Assignee

Comment 2

2 years ago
shape-outside-inset-027.html indeed passes on Windows. object-position-png-002c.html passes on styloVsGecko on Windows without fuzzy: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a69b6c286568cfc02aa69e83460f297742f00a5

Need to see whether object-position-png-002c.html passes on styloVsGecko everywhere.
Assignee

Comment 3

2 years ago
Looks like object-position-png-002c.html simply passes everywhere for styloVsGecko: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a05d78d8f7da15ac447fed646f3c06a026bf39e3
Assignee

Updated

2 years ago
Summary: stylo: Fix skipped and random-if tests in layout/reftests/forms/ → stylo: Fix skipped and random-if tests in layout/reftests/w3c-css/submitted
Assignee

Comment 5

2 years ago
mozreview-review
Comment on attachment 8904127 [details]
Bug 1396147 - Update annotation for tests mentioned in this bug.

https://reviewboard.mozilla.org/r/175912/#review180880
Attachment #8904127 - Flags: review+

Comment 6

2 years ago
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cef1935ebd9b
Update annotation for tests mentioned in this bug. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/cef1935ebd9b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee: nobody → xidorn+moz
You need to log in before you can comment on or make changes to this bug.