Closed
Bug 1396147
Opened 7 years ago
Closed 7 years ago
stylo: Fix skipped and random-if tests in layout/reftests/w3c-css/submitted
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | wontfix |
firefox57 | --- | fixed |
People
(Reporter: cpeterson, Assigned: xidorn)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
> layout/reftests/w3c-css/submitted/images3/reftest.list > 179 fails-if(!styloVsGecko&&!webrender) fuzzy-if(styloVsGecko,11,388) == object-position-png-002c.html object-position-png-002-ref.html # bug 1105150 This test appears to fail in both Stylo and Gecko. It only "passes" in styloVsGecko because they both fail. The annotation should probably be changed to `fails-if(!webrender)`. > layout/reftests/forms/input/number/reftest.list > 99 skip-if(stylo&&winWidget) == shape-outside-inset-027.html shape-outside-inset-027-ref.html Why is this test skipped only for Stylo on Windows?
Assignee | ||
Comment 1•7 years ago
|
||
shape-outside-inset-027.html is in layout/reftests/w3c-css/submitted/shapes1 And it seems to me this test passes on Windows locally. I guess we can just enable it.
Assignee | ||
Comment 2•7 years ago
|
||
shape-outside-inset-027.html indeed passes on Windows. object-position-png-002c.html passes on styloVsGecko on Windows without fuzzy: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a69b6c286568cfc02aa69e83460f297742f00a5 Need to see whether object-position-png-002c.html passes on styloVsGecko everywhere.
Assignee | ||
Comment 3•7 years ago
|
||
Looks like object-position-png-002c.html simply passes everywhere for styloVsGecko: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a05d78d8f7da15ac447fed646f3c06a026bf39e3
Assignee | ||
Updated•7 years ago
|
Summary: stylo: Fix skipped and random-if tests in layout/reftests/forms/ → stylo: Fix skipped and random-if tests in layout/reftests/w3c-css/submitted
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8904127 [details] Bug 1396147 - Update annotation for tests mentioned in this bug. https://reviewboard.mozilla.org/r/175912/#review180880
Attachment #8904127 -
Flags: review+
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cef1935ebd9b Update annotation for tests mentioned in this bug. r=xidorn
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cef1935ebd9b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•6 years ago
|
Assignee: nobody → xidorn+moz
You need to log in
before you can comment on or make changes to this bug.
Description
•