Closed
Bug 1396158
Opened 7 years ago
Closed 7 years ago
remove pocketsphinx
Categories
(Core :: Web Speech, enhancement)
Core
Web Speech
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: rillian, Assigned: rillian)
References
Details
Attachments
(2 files)
We have a copy of pocketsphinx in the tree which was used for local speech recognition on b2g. It's no longer used in any supported builds and seems to have bit-rotted a bit. I propose removing it.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8903860 -
Flags: review?(cmanchester)
Assignee | ||
Comment 2•7 years ago
|
||
Kelly, there's an old implementation of the webspeech recognition API left over from the b2g days, but it's bit-rotting. Are you still using the pocketsphinx back-end in your work, or can we remove it? I have a patch for this, but it's too large and I can't attach it to bugzilla or reviewboard.
Flags: needinfo?(kdavis)
Assignee | ||
Comment 3•7 years ago
|
||
Here's the commit on github for reference.
Attachment #8903862 -
Flags: review?(kdavis)
Attachment #8903862 -
Flags: review?(cmanchester)
Now one is using the old implementation of the webspeech recognition API that I am aware of. The only external facing things I'm aware of that reference the Web Speech API are the MDN articles [https://mzl.la/2vBYk8z] and [https://mzl.la/2iS9tfn] that reference how to use the API in Firefox OS.
Flags: needinfo?(kdavis)
Assignee | ||
Comment 5•7 years ago
|
||
Ok, thanks. Sounds like it's safe to remove the implementation then.
Yeah it's safe to remove. I'll review the code tomorrow; I scheduled time yesterday to do it, but my time was eaten by another code review. :-)
Updated•7 years ago
|
Attachment #8903860 -
Flags: review?(cmanchester) → review+
Comment 7•7 years ago
|
||
Comment on attachment 8903862 [details]
Part 2 - Remove pocketsphinx
Skimming this it looks like a straightforward deletion without removing other integration code in the tree. If so, looks good to me!
Attachment #8903862 -
Flags: review?(cmanchester) → review+
Assignee | ||
Comment 8•7 years ago
|
||
(In reply to Chris Manchester (:chmanchester) from comment #7) > Skimming this it looks like a straightforward deletion without removing > other integration code in the tree. If so, looks good to me! That's correct. Thanks for reviewing. Looking forward to kdavis' review tomorrow.
Attachment #8903862 -
Flags: review?(kdavis) → review+
Pushed by rgiles@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7d531ca836a5 Remove pocketsphinx references from the build system. r=chmanchester https://hg.mozilla.org/integration/mozilla-inbound/rev/bbc8ae1a9936 Remove pocketsphinx. r=kdavis,chmanchester
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7d531ca836a5 https://hg.mozilla.org/mozilla-central/rev/bbc8ae1a9936
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•