Intermittent devtools/client/styleeditor/test/browser_styleeditor_opentab.js | The menu item is disabled - Got false, expected true

RESOLVED FIXED in Firefox 57

Status

()

Firefox
Developer Tools: Style Editor
P2
normal
RESOLVED FIXED
9 months ago
8 months ago

People

(Reporter: Treeherder Bug Filer, Assigned: pbro)

Tracking

(Blocks: 1 bug, {intermittent-failure})

unspecified
Firefox 57
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [stockwell fixed:other])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment 1

9 months ago
10 failures in 939 pushes (0.011 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* try: 4
* mozilla-central: 3
* autoland: 2
* mozilla-inbound: 1

Platform breakdown:
* windows10-64: 5
* windows7-32-nightly: 2
* windows7-32: 2
* windows7-32-devedition: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1396182&startday=2017-08-28&endday=2017-09-03&tree=all

Comment 2

9 months ago
26 failures in 173 pushes (0.15 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* try: 11
* mozilla-inbound: 7
* autoland: 7
* mozilla-central: 1

Platform breakdown:
* windows10-64: 13
* windows7-32: 9
* windows7-32-devedition: 2
* windows7-32-nightly: 1
* windows10-64-devedition: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1396182&startday=2017-09-08&endday=2017-09-08&tree=all

Comment 3

9 months ago
24 failures in 64 pushes (0.375 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 10
* try: 5
* autoland: 5
* mozilla-central: 4

Platform breakdown:
* windows10-64: 12
* windows7-32: 9
* windows7-32-nightly: 1
* linux64-stylo-disabled: 1
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1396182&startday=2017-09-09&endday=2017-09-09&tree=all

Comment 4

9 months ago
120 failures in 924 pushes (0.13 failures/push) were associated with this bug in the last 7 days. 

This is the #19 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **  

Repository breakdown:
* try: 40
* mozilla-inbound: 34
* autoland: 34
* mozilla-central: 12

Platform breakdown:
* windows10-64: 56
* windows7-32: 44
* windows7-32-nightly: 5
* windows7-32-devedition: 4
* windows10-64-devedition: 3
* linux64: 3
* windows10-64-nightly: 2
* macosx64-nightly: 2
* linux64-stylo-disabled: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1396182&startday=2017-09-04&endday=2017-09-10&tree=all
(Assignee)

Comment 5

9 months ago
This started 9 days ago. I have a hunch this started with bug 1379099, because in that bug we added an animation in the sidebar, where the context menu is supposed to be displayed. So maybe this introduced a timing issue when the test tries to show the menu.
Priority: P5 → P2
(Assignee)

Updated

9 months ago
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 9

9 months ago
15 failures in 159 pushes (0.094 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* try: 10
* mozilla-inbound: 2
* autoland: 2
* mozilla-central: 1

Platform breakdown:
* windows10-64: 6
* windows7-32: 5
* windows7-32-devedition: 2
* windows7-32-nightly: 1
* windows10-64-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1396182&startday=2017-09-11&endday=2017-09-11&tree=all

Comment 10

9 months ago
mozreview-review
Comment on attachment 8906517 [details]
Bug 1396182 - Wait for the styleditor animations to be done before running tests;

https://reviewboard.mozilla.org/r/178268/#review183848

::: devtools/client/styleeditor/test/head.js:91
(Diff revision 2)
> +  // animation is done. So we listen to it here so tests don't have to and can't miss it.
> +  let onMediaListChanged = ui.once("media-list-changed");
> +
> +  // The stylesheet list appears with an animation. Let this animation finish.
> +  let animations = ui._root.getAnimations({subtree: true});
> +  yield Promise.all(animations.map(a => a.finished));

Isn't that related to this async code:
http://searchfox.org/mozilla-central/source/devtools/client/styleeditor/StyleSheetEditor.jsm#129-130     
  this.cssSheet.getMediaRules().then(this._onMediaRulesChanged, console.error);

Then, shouldn't we instead wait for it to finish by introducing StyleSheetEditor.init method returning a promise and we would wait for it to finish from here:
http://searchfox.org/mozilla-central/source/devtools/client/styleeditor/StyleEditorUI.jsm#392
Like we do for fetchSource().

This would allow tracking this on DAMP, and also benefit to any code relying on showToolbox("styleditor").
Attachment #8906517 - Flags: review?(poirot.alex) → review+
r+ as it looks like a reasonable fix just for test, but I would really like us fix showToolbox/DAMP and really reflect what users see. These animations are definitely part of the load time and should be tracked for perf regression.

Comment 12

9 months ago
21 failures in 162 pushes (0.13 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 10
* autoland: 7
* mozilla-central: 4

Platform breakdown:
* windows10-64: 16
* windows7-32: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1396182&startday=2017-09-12&endday=2017-09-12&tree=all

Comment 13

9 months ago
36 failures in 247 pushes (0.146 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 13
* try: 12
* autoland: 8
* mozilla-central: 3

Platform breakdown:
* windows10-64: 19
* windows7-32: 11
* windows7-32-nightly: 2
* windows7-32-devedition: 2
* macosx64-nightly: 1
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1396182&startday=2017-09-13&endday=2017-09-13&tree=all
(Assignee)

Comment 14

9 months ago
mozreview-review-reply
Comment on attachment 8906517 [details]
Bug 1396182 - Wait for the styleditor animations to be done before running tests;

https://reviewboard.mozilla.org/r/178268/#review183848

> Isn't that related to this async code:
> http://searchfox.org/mozilla-central/source/devtools/client/styleeditor/StyleSheetEditor.jsm#129-130     
>   this.cssSheet.getMediaRules().then(this._onMediaRulesChanged, console.error);
> 
> Then, shouldn't we instead wait for it to finish by introducing StyleSheetEditor.init method returning a promise and we would wait for it to finish from here:
> http://searchfox.org/mozilla-central/source/devtools/client/styleeditor/StyleEditorUI.jsm#392
> Like we do for fetchSource().
> 
> This would allow tracking this on DAMP, and also benefit to any code relying on showToolbox("styleditor").

True. Let's land this test fix as the intermittent is quite frequent. I'll file the next bug to take care of showToolbox being more realistic.

Comment 15

9 months ago
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b4360780665
Wait for the styleditor animations to be done before running tests; r=ochameau
(Assignee)

Updated

9 months ago
Blocks: 1399779
Whiteboard: [stockwell fixed:other]
https://hg.mozilla.org/mozilla-central/rev/2b4360780665
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57

Comment 17

9 months ago
21 failures in 191 pushes (0.11 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* mozilla-central: 9
* try: 5
* mozilla-inbound: 5
* autoland: 2

Platform breakdown:
* windows10-64: 10
* windows7-32: 6
* windows10-64-nightly: 2
* windows7-32-nightly: 1
* windows10-64-devedition: 1
* linux32-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1396182&startday=2017-09-14&endday=2017-09-14&tree=all

Comment 18

8 months ago
115 failures in 1032 pushes (0.111 failures/push) were associated with this bug in the last 7 days. 

This is the #20 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **   

Repository breakdown:
* try: 42
* mozilla-inbound: 29
* mozilla-central: 23
* autoland: 21

Platform breakdown:
* windows10-64: 64
* windows7-32: 34
* windows7-32-devedition: 5
* windows7-32-nightly: 4
* windows10-64-nightly: 3
* linux32-nightly: 2
* windows10-64-devedition: 1
* macosx64-nightly: 1
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1396182&startday=2017-09-11&endday=2017-09-17&tree=all
You need to log in before you can comment on or make changes to this bug.