Closed Bug 1396218 Opened 7 years ago Closed 7 years ago

Mixed Mozmill failure 2017-09-02: 17 failures

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 57.0

People

(Reporter: jorgk-bmo, Unassigned)

References

Details

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/cloudfile/test-cloudfile-attachment-urls.js | test-cloudfile-attachment-urls.js::test_adding_filelinks_to_nonempty_reply_above TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/cloudfile/test-cloudfile-attachment-urls.js | test-cloudfile-attachment-urls.js::test_adding_filelinks_to_empty_reply_below TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/cloudfile/test-cloudfile-attachment-urls.js | test-cloudfile-attachment-urls.js::test_adding_filelinks_to_nonempty_reply_below TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/cloudfile/test-cloudfile-attachment-urls.js | test-cloudfile-attachment-urls.js::test_adding_filelinks_to_forward TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/cloudfile/test-cloudfile-attachment-urls.js | test-cloudfile-attachment-urls.js::test_insertion_restores_caret_point TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/composition/test-drafts.js | test-drafts.js::test_remove_space_stuffing_format_flowed TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/composition/test-forward-headers.js | test-forward-headers.js::test_forward_inline TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/composition/test-forward-headers.js | test-forward-headers.js::test_forward_as_attachments TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/composition/test-forward-rfc822-attach.js | test-forward-rfc822-attach.js::test_forwarding_long_html_line_as_attachment TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/composition/test-forward-rfc822-attach.js | test-forward-rfc822-attach.js::test_forwarding_feed_message_as_attachment TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/composition/test-forwarded-content.js | test-forwarded-content.js::test_forwarded_subj TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/composition/test-image-display.js | test-image-display.js::test_cid_image_compose TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/composition/test-image-insertion-dialog.js | test-image-insertion-dialog.js::test_image_insertion_dialog_persist TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/composition/test-multipart-related.js | test-multipart-related.js::test_basic_multipart_related TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/composition/test-newmsg-compose-identity.js | test-newmsg-compose-identity.js::test_display_of_identities TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/composition/test-reply-format-flowed.js | test-reply-format-flowed.js::test_reply_format_flowed TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/mozmill/composition/test-send-format.js | test-send-format.js::test_msg_convertibility First seen Sat Sep 2, 2017: 8:51:37 https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=f5394bcc7c1b41f1c8a2b1a8037a643a080b377f M-C last good: 73e8f351b28ffc30e8077be21ce7298f46 M-C first bad: 5278dfcf5eb9f58eaf06ad1ce67e7fd4ab https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=73e8f351b28ffc30e8077be21ce7298f46&tochange=5278dfcf5eb9f58eaf06ad1ce67e7fd4ab Log says: https://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-win32/1504335140/comm-central_win7_ix_test-mozmill-bm111-tests1-windows-build39.txt.gz INFO - SUMMARY-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-reply-format-flowed.js | test-reply-format-flowed.js::test_reply_format_flowed INFO - EXCEPTION: Expected line not found in message. INFO - at: test-folder-display-helpers.js line 2890 INFO - assert_true test-folder-display-helpers.js:2890 11 INFO - subtest_reply_format_flowed test-reply-format-flowed.js:56 3 INFO - test_reply_format_flowed test-reply-format-flowed.js:67 3 or INFO - SUMMARY-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-send-format.js | test-send-format.js::test_msg_convertibility INFO - EXCEPTION: a != b: '1' != '3'. INFO - at: test-folder-display-helpers.js line 2890 INFO - assert_true test-folder-display-helpers.js:2890 11 INFO - assert_equals test-folder-display-helpers.js:2877 3 INFO - checkMsgFile test-send-format.js:36 3 INFO - test_msg_convertibility test-send-format.js:49 3 Also heaps of failures here: https://treeherder.mozilla.org/logviewer.html#?job_id=127966092&repo=comm-central&lineNumber=3772 So somehow tests related to editing a message in the compose window fail. Aceman, if you're bored this weekend ... Could be: dd99274926b8 Boris Zbarsky — Bug 1395701 part 2. Use a linked list, not a hashtable, for registering selection ranges on a node, so the registration will be faster. r=ehsan 11e80634f034 Boris Zbarsky — Bug 1395701 part 1. Maintain the "registered common ancestor" in a member on selection ranges. r=ehsan bc499bee82e2 Boris Zbarsky — Bug 1395715. When recovering letter frames, only do first-line fixup when we have a first-line parent. r=emilio d2305bd57a97 Ehsan Akhgari — Bug 1393140 - Rewrite EditorBase::FindBetterInsertionPoint() without using nsINode::GetChildAt(); r=masayuki FRG, what's your best bet?
Flags: needinfo?(frgrahl)
Flags: needinfo?(acelists)
Also not so nice: INFO - SUMMARY-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\cloudfile\test-cloudfile-attachment-urls.js | test-cloudfile-attachment-urls.js::test_adding_filelinks_to_nonempty_reply_above INFO - EXCEPTION: The linebreak should be followed by a div: 'br' != 'div'. INFO - at: test-folder-display-helpers.js line 2890 INFO - assert_true test-folder-display-helpers.js:2890 11 INFO - assert_equals test-folder-display-helpers.js:2877 3 INFO - subtest_adding_filelinks_to_reply_above_plaintext test-cloudfile-attachment-urls.js:441 3 INFO - test_adding_filelinks_to_nonempty_reply_above test-cloudfile-attachment-urls.js:419 3
Also in the log: JavaScript error: resource://mozmill/modules/frame.js -> file:///C:/slave/test/build/tests/mozmill/shared-modules/test-window-helpers.js, line 372: Error: Timeout while waiting for modal dialog. And also: 01:20:20 INFO - SUMMARY-PASS | test-forward-rfc822-attach.js::setupModule 01:20:20 INFO - SUMMARY-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\composition\test-forward-rfc822-attach.js | test-forward-rfc822-attach.js::test_forwarding_long_html_line_as_attachment 01:20:20 INFO - EXCEPTION: Failed to find expected text 01:20:20 INFO - at: test-folder-display-helpers.js line 2890 01:20:20 INFO - assert_true test-folder-display-helpers.js:2890 11 01:20:20 INFO - forwardDirect test-forward-rfc822-attach.js:51 5 01:20:20 INFO - test_forwarding_long_html_line_as_attachment test-forward-rfc822-attach.js:58 3 That's a very short test which only does some forwarding. Maybe something wrong with getting the content of the resulting message which is obtained with get_msg_source(). But then there are other tests using that function which haven't failed. I'll stop speculating when my build is done ;-)
Bug 1393140 seems to be the most likely candidate. Then Bug 1395701. Other than the three bugs I am not seeing much else in the list what could have caused it.
Flags: needinfo?(frgrahl)
I ran these manually: mozmake SOLO_TEST=composition/test-multipart-related.js mozmill-one mozmake SOLO_TEST=composition/test-reply-format-flowed.js mozmill-one mozmake SOLO_TEST=composition/test-image-display.js mozmill-one mozmake SOLO_TEST=composition/test-forward-rfc822-attach.js mozmill-one with M-C at 5278dfcf5eb9 and they all *PASS*. And I have neutral witness from Switzerland here ;-)
OK, the first one in 'composition' mozmake SOLO_TEST=composition/test-drafts.js mozmill-one doesn't work and most likely kills the following ones by not cleaning up. SUMMARY-UNEXPECTED-FAIL | c:\mozilla-source\comm-central\mail\test\mozmill\composition\test-drafts.js | test-drafts.js::test_remove_space_stuffing_format_flowed EXCEPTION: Something went wrong with space stuffing at: test-folder-display-helpers.js line 2890 assert_true test-folder-display-helpers.js:2890 11 test_remove_space_stuffing_format_flowed test-drafts.js:268 5
Caused by d2305bd57a97 Ehsan Akhgari — Bug 1393140 - Rewrite EditorBase::FindBetterInsertionPoint() without using nsINode::GetChildAt(); r=masayuki
Blocks: 1393140
Yes, I also chose a random test in the list and it passed locally (with updated m-c). test-drafts.js::test_remove_space_stuffing_format_flowed does fail.
Flags: needinfo?(acelists)
Let's see what's left when switching off test-drafts.js::test_remove_space_stuffing_format_flowed. https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=dabec810a34c764119038f6ab3fec21ca208f11a I suppose test-cloudfile-attachment-urls.js (various) will also fail and nothing else, fingers crossed. Aceman, can you see why this is failing?
Do this locally: Start a plain text e-mail, type |xx<enter><space>|, the space goes after the xx and the enter is lost. Nothing we can fix here.
Yes, that happens. It's with any number of Enters, the cursor returns back the to last line with letters (which is the first line of a new composition). That looks like totally broken.
Fixed by backout of bug 1393140.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 57.0
You need to log in before you can comment on or make changes to this bug.