Closed Bug 1396219 Opened 7 years ago Closed 7 years ago

Support PerformanceObserverInit.buffered

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

()

Details

Attachments

(2 files)

This is a reason why po-observe.html fails. Another reason why the test fails is that we don't support navigation timing yet (bug 1043083)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce0a6e85e465532f639f318a37bac3822704ec46

Note that po-observe.html does check PerformanceEntry.type instead of 'entryType' so that the test will not pass even after we implemented navigation timing. I did send a PR to fix it to upsteam <https://github.com/w3c/web-platform-tests/pull/7230>.
Relevant part of the spec <https://w3c.github.io/performance-timeline/#the-performanceobserver-interface>;

5. If options' buffered flag is set, for each entryType of the entryTypes sequence:

    1. Let entries be the PerformanceEntryList object returned by the 4.2 Filter buffer by name and type algorithm with buffer set to performance entry buffer, name set to null and type set to entryType.
    2. Append entries to the context object's observer buffer.
Comment on attachment 8903972 [details]
Bug 1396219 - Support PerformanceObserverInit.buffered.

https://reviewboard.mozilla.org/r/175728/#review181002
Attachment #8903972 - Flags: review?(amarchesini) → review+
Comment on attachment 8903973 [details]
Bug 1396219 - Add a bug number for failure reason.

https://reviewboard.mozilla.org/r/175730/#review181004
Attachment #8903973 - Flags: review?(amarchesini) → review+
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18ab7bccc225
Support PerformanceObserverInit.buffered. r=baku
https://hg.mozilla.org/integration/autoland/rev/e225049ffeb2
Add a bug number for failure reason. r=baku
Assignee: nobody → hikezoe
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.