Closed Bug 1396277 Opened 2 years ago Closed 2 years ago

Make the gloda autocomplete popup nicer

Categories

(Thunderbird :: Theme, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 57.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

The gloda autocomplete popup has no hover effect. Also is the text not aligned with the text in the searchfield.
I used the same colors FX uses for the URL autocomplete popup.

I also removed the --toolbarbutton-border-radius variable in searcjBox.css because messenger.css, where the variable is defined, isn't loaded in about:downloads and we get an error in the console.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8903936 - Flags: review?(jorgk)
Attachment #8903936 - Flags: review?(acelists)
Comment on attachment 8903936 [details] [diff] [review]
GlodaAutocomplete.patch

Review of attachment 8903936 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me on Linux. The hovered background is very light (tried under Monterail), but better than nothing.
Attachment #8903936 - Flags: review?(acelists) → review+
Comment on attachment 8903936 [details] [diff] [review]
GlodaAutocomplete.patch

Works for me, light grey hover colour and better alignment.
Attachment #8903936 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/023a7bb58405
Add hover to gloda autocomplete popup and fix alignment. r=jorgk,aceman
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 57.0
You need to log in before you can comment on or make changes to this bug.