Helper app prompt for downloads broken

RESOLVED FIXED in Firefox 57

Status

()

defect
--
major
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: JanH, Assigned: JanH)

Tracking

({regression})

57 Branch
Firefox 57
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 unaffected, firefox57 fixed)

Details

Attachments

(1 attachment)

Downloading a file that used to trigger the helper app prompt no longer works:
The loading indicator momentarily flashes up, disappears again and that's it.

In the console I'm seeing errors like:
09-02 23:07:38.110 20481-20525/org.mozilla.fennec_jan E/GeckoConsole: [JavaScript Error: "TypeError: chrome.browserAction.setIcon is not a function" {file: "moz-extension://8ad8b3e5-63a5-4507-af20-5e533fe80c27/background/background.js" line: 294}]
09-02 23:07:39.065 20481-20525/org.mozilla.fennec_jan E/GeckoConsole: [JavaScript Error: "ReferenceError: assignment to undeclared variable useNewButtonOrder" {file: "jar:jar:file:///data/app/org.mozilla.fennec_jan-2/base.apk!/assets/omni.ja!/components/HelperAppDialog.js" line: 254}]
I should have looked more closely - the first line comes from an extension and is unrelated. The other line indicates an embarrassing typo (by me no less) that's been caught through the recent enabling of strict mode in bug 1394556.

I think APK downloads should always trigger the helper app dialogue, so this URL should work for demonstrating the issue:
http://ftp.mozilla.org/pub/mobile/nightly/latest-mozilla-central-android-api-16/fennec-57.0a1.multi.android-arm.apk
Assignee: nobody → jh+bugzilla
Blocks: 1394556
Has Regression Range: --- → yes
Has STR: --- → yes
See Also: → 1396426
Assignee

Comment 3

2 years ago
mozreview-review
Comment on attachment 8904065 [details]
Bug 1396303 - Fix typo in variable declaration that breaks the download helper app dialogue.

https://reviewboard.mozilla.org/r/175808/#review180790
Attachment #8904065 - Flags: review+

Comment 4

2 years ago
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/2312d14f17c4
Fix typo in variable declaration that breaks the download helper app dialogue. r=JanH
https://hg.mozilla.org/mozilla-central/rev/2312d14f17c4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
The fix turned out easier than expected, so I guess no need to track this anymore.
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.