Closed Bug 1396335 Opened 2 years ago Closed 2 years ago

Clean up unnecessary styles in toolbox.css

Categories

(DevTools :: General, defect, P3)

defect

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

There are some style rules in the toolbox.css that can be cleaned up because they are either having no effect or they are unnecessary.
Attachment #8903978 - Flags: review?(pbrosset)
Comment on attachment 8903978 [details] [diff] [review]
1396335.patch [1.0]

Review of attachment 8903978 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/themes/toolbox.css
@@ -278,5 @@
>  #toolbox-dock-bottom-minimize.minimized::before {
>    background-image: url("chrome://devtools/skin/images/dock-bottom-maximize@2x.png");
>  }
> -/**
> - * Ensure that when the toolbar collapses in on itself when there is not enough room

This rule seemed to be needed for some kind of edge case. It might be worth looking at the history for this change and making sure we're not re-introducing a bug that was once fixed.
Seems to have been introduced with bug 1245921 8 months ago.
Attachment #8903978 - Flags: review?(pbrosset) → review+
(In reply to Patrick Brosset <:pbro> from comment #2)
> Comment on attachment 8903978 [details] [diff] [review]
> 1396335.patch [1.0]
> 
> Review of attachment 8903978 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: devtools/client/themes/toolbox.css
> @@ -278,5 @@
> >  #toolbox-dock-bottom-minimize.minimized::before {
> >    background-image: url("chrome://devtools/skin/images/dock-bottom-maximize@2x.png");
> >  }
> > -/**
> > - * Ensure that when the toolbar collapses in on itself when there is not enough room
> 
> This rule seemed to be needed for some kind of edge case. It might be worth
> looking at the history for this change and making sure we're not
> re-introducing a bug that was once fixed.
> Seems to have been introduced with bug 1245921 8 months ago.

I actually checked with the Greg to see what the edge cases were, and we believe this is no longer needed with the recent changes to the toolbox tabs.
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ce738a78567
Clean up unnecessary style rules in toolbox.css. r=pbro
https://hg.mozilla.org/mozilla-central/rev/4ce738a78567
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.