Closed
Bug 1396345
Opened 7 years ago
Closed 7 years ago
Add a separator between the clear and filter buttons
Categories
(DevTools :: Console, enhancement, P3)
DevTools
Console
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.29 KB,
patch
|
nchevobbe
:
review+
|
Details | Diff | Splinter Review |
As part of the photon designs for photon, there is a separator line similar to the element picker between the clear and filter button in the filter toolbar.
Assignee | ||
Updated•7 years ago
|
Blocks: devtools-visual
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8903991 -
Flags: review?(nchevobbe)
Comment 2•7 years ago
|
||
Comment on attachment 8903991 [details] [diff] [review] 1396345.patch [1.0] Review of attachment 8903991 [details] [diff] [review]: ----------------------------------------------------------------- Shouldn't there be one between the filter button and the filter input as well ?
Attachment #8903991 -
Flags: review?(nchevobbe) → review+
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #2) > Comment on attachment 8903991 [details] [diff] [review] > 1396345.patch [1.0] > > Review of attachment 8903991 [details] [diff] [review]: > ----------------------------------------------------------------- > > Shouldn't there be one between the filter button and the filter input as > well ? I don't see it on any mockups. I am gonna just land as-is since it's an easy addition.
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c77149fc1187 Add a separator between the clear and filter buttons in the console. r=nchevobbe
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c77149fc1187
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•