Closed Bug 1396347 Opened 4 years ago Closed 4 years ago

Accordion and headers should only be 24px in height

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

According to the photon specs for devtools, the accordion and headers should only have a total height of 24px including border.
Attached patch 1396347.patchSplinter Review
Attachment #8903992 - Flags: review?(pbrosset)
Comment on attachment 8903992 [details] [diff] [review]
1396347.patch

Review of attachment 8903992 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Are you also changing the accordion in debugger.html on github? I don't think we're sharing the code for this component yet unfortunately.
Attachment #8903992 - Flags: review?(pbrosset) → review+
(In reply to Patrick Brosset <:pbro> from comment #2)
> Comment on attachment 8903992 [details] [diff] [review]
> 1396347.patch
> 
> Review of attachment 8903992 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good. Are you also changing the accordion in debugger.html on github?
> I don't think we're sharing the code for this component yet unfortunately.

Changes already landed on the debugger.html on Github
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3037a3d59eb
Accordion and headers should only be 24px in height. r=pbro
https://hg.mozilla.org/mozilla-central/rev/a3037a3d59eb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.