Accordion and headers should only be 24px in height

RESOLVED FIXED in Firefox 57

Status

enhancement
P3
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: gl, Assigned: gl)

Tracking

(Blocks 1 bug)

unspecified
Firefox 57
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

According to the photon specs for devtools, the accordion and headers should only have a total height of 24px including border.
Posted patch 1396347.patchSplinter Review
Attachment #8903992 - Flags: review?(pbrosset)
Comment on attachment 8903992 [details] [diff] [review]
1396347.patch

Review of attachment 8903992 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Are you also changing the accordion in debugger.html on github? I don't think we're sharing the code for this component yet unfortunately.
Attachment #8903992 - Flags: review?(pbrosset) → review+
(In reply to Patrick Brosset <:pbro> from comment #2)
> Comment on attachment 8903992 [details] [diff] [review]
> 1396347.patch
> 
> Review of attachment 8903992 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good. Are you also changing the accordion in debugger.html on github?
> I don't think we're sharing the code for this component yet unfortunately.

Changes already landed on the debugger.html on Github
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3037a3d59eb
Accordion and headers should only be 24px in height. r=pbro
https://hg.mozilla.org/mozilla-central/rev/a3037a3d59eb
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.