If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove the collapse sidebar pane button in the Inspector

ASSIGNED
Assigned to

Status

()

Firefox
Developer Tools: Inspector
P3
normal
ASSIGNED
20 days ago
5 days ago

People

(Reporter: gl, Assigned: gl)

Tracking

(Blocks: 1 bug)

unspecified
Points:
---

Firefox Tracking Flags

(firefox57 fix-optional)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

20 days ago
Created attachment 8903995 [details] [diff] [review]
1396349.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c014f4463f2ad2db4fea72200de546c9d5bd885d
Attachment #8903995 - Flags: review?(pbrosset)
(Assignee)

Comment 2

20 days ago
Created attachment 8903996 [details] [diff] [review]
1396349.patch [1.0]
Attachment #8903996 - Flags: review?(pbrosset)
(Assignee)

Updated

20 days ago
Attachment #8903995 - Attachment is obsolete: true
Attachment #8903995 - Flags: review?(pbrosset)
Why are we removing the collapse button? Can you point to mockups and reasons that show and explain the change?
Other sidebars in the toolbox are collapsible (netmonitor, storage, debugger), are we going to make them non-collapsible too?
Flags: needinfo?(gl)
(Assignee)

Comment 4

19 days ago
This is under inspector light in https://docs.google.com/document/d/1AJ7oHC7akXJiliheHjhFc4fTonaN31Eo_P2M8gssL8s/edit#heading=h.36hd86a2u1dp. We are actually removing that entire toolbar and making the search bar expandable like the debugger. The reasoning for this is a 2 parter:
(1) We already have a conceptual model from the debugger and code editors that search prompts appear from cmd/ctrl + F.
(2) Regain some of the vertical height from things getting bigger.

So, the next question will probably be what happens to the Add New Node and Color picker button. The Color picker seems to be moving to the bottom and going with the breadcrumbs. The mockup doesn't actually keep the add new node button anywhere, but presumably it can go next to the color picker as well. 

The mockup also shows removal of the collapse button of the debugger. I think there is a plan to adopt the way Atom collapses sidebars.

For now, it seems removing the collapse button seems relatively safe for the inspector since we rarely would want to hide the sidebar and Chrome doesn't do it.
Flags: needinfo?(gl)
(In reply to Gabriel [:gl] (ΦωΦ) from comment #4)
> This is under inspector light in
> https://docs.google.com/document/d/
> 1AJ7oHC7akXJiliheHjhFc4fTonaN31Eo_P2M8gssL8s/edit#heading=h.36hd86a2u1dp. We
> are actually removing that entire toolbar and making the search bar
> expandable like the debugger. The reasoning for this is a 2 parter:
> (1) We already have a conceptual model from the debugger and code editors
> that search prompts appear from cmd/ctrl + F.
> (2) Regain some of the vertical height from things getting bigger.
Regaining vertical height sounds good, and having the same search experience across tools too (although the debugger has a clickable area to trigger the search tool too).
I guess I'm just worried about removing a feature. We've done this in the past and it's always been hard.

> So, the next question will probably be what happens to the Add New Node and
> Color picker button. The Color picker seems to be moving to the bottom and
> going with the breadcrumbs. The mockup doesn't actually keep the add new
> node button anywhere, but presumably it can go next to the color picker as
> well. 
Sure. That would work. In any case, we should keep the add node button. We have one in the rule-view too. And it's an important feature when you think of the designer workflow idea.

> The mockup also shows removal of the collapse button of the debugger. I
> think there is a plan to adopt the way Atom collapses sidebars.
Oh ok. I was not aware with this so I downloaded Atom. I see what you mean now.
Are we adding this at the same time as we're removing the collapse buttons? I suggest we do. To avoid removing a feature and then later re-introducing it differently.

> For now, it seems removing the collapse button seems relatively safe for the
> inspector since we rarely would want to hide the sidebar and Chrome doesn't
> do it.
Hmm, I don't know if we can make such a call. How do you know we rarely want to hide the sidebar?

I really like all the Photon style refresh Victoria and you have been doing in 57. I would advise the following: let's land as much as can in terms of color and tab changes. 57's cycle is almost over, so I think it's safe to land those 2 changes because they're already in nightly and really safe.
But I would advise against landing feature changes in 57. If we just wait a couple weeks, then we can land in 58 both the removal of collapse icons and the new Atom-like collapsers, across all tools. Rather than just remove the inspector icon, which will seem arbitrary to our users.
(Assignee)

Comment 6

18 days ago
I think this meets my expectation for landing after 57 as well.
Comment on attachment 8903996 [details] [diff] [review]
1396349.patch [1.0]

Review of attachment 8903996 [details] [diff] [review]:
-----------------------------------------------------------------

Simple code removal. No problem for me to R+ apart from the conversation we just had related to landing in 58 along with the new sidebar collapse UX.
Attachment #8903996 - Flags: review?(pbrosset) → review+
status-firefox57: --- → fix-optional
You need to log in before you can comment on or make changes to this bug.