Closed
Bug 1396398
Opened 7 years ago
Closed 7 years ago
wrong comment for MAGIC_NUMBER in lz4.js
Categories
(Toolkit Graveyard :: OS.File, defect)
Toolkit Graveyard
OS.File
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
|
1.17 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
https://dxr.mozilla.org/mozilla-central/rev/f5d99e9f3d7bf19c8a222db97bedc924da27fd58/toolkit/components/lz4/lz4.js#28 > const MAGIC_NUMBER = new Uint8Array([109, 111, 122, 76, 122, 52, 48, 0]); // "mozLz4a\0" it's "mozLz40\0", not "mozLz4a\0"
|
Assignee | |
Updated•7 years ago
|
Version: 53 Branch → Trunk
|
|
Assignee | |
Comment 1•7 years ago
|
||
Comment on attachment 8904028 [details] [diff] [review] Fix comment for MAGIC_NUMBER. Review of attachment 8904028 [details] [diff] [review]: ----------------------------------------------------------------- Good catch, thanks.
Attachment #8904028 -
Flags: review?(dteller) → review+
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1d76fe320d1a Fix comment for MAGIC_NUMBER. r=Yoric
|
|
Assignee | |
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d76fe320d1a10c903ea139296c35bde38136db8 Bug 1396398 - Fix comment for MAGIC_NUMBER. r=Yoric
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1d76fe320d1a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Updated•11 months ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•