wrong comment for MAGIC_NUMBER in lz4.js

RESOLVED FIXED in Firefox 57

Status

()

Toolkit
OS.File
--
trivial
RESOLVED FIXED
2 months ago
29 days ago

People

(Reporter: arai, Assigned: arai)

Tracking

Trunk
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
https://dxr.mozilla.org/mozilla-central/rev/f5d99e9f3d7bf19c8a222db97bedc924da27fd58/toolkit/components/lz4/lz4.js#28
> const MAGIC_NUMBER = new Uint8Array([109, 111, 122, 76, 122, 52, 48, 0]); // "mozLz4a\0"

it's "mozLz40\0", not "mozLz4a\0"
(Assignee)

Updated

2 months ago
Version: 53 Branch → Trunk
(Assignee)

Comment 1

2 months ago
Created attachment 8904028 [details] [diff] [review]
Fix comment for MAGIC_NUMBER.
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Attachment #8904028 - Flags: review?(dteller)
Comment on attachment 8904028 [details] [diff] [review]
Fix comment for MAGIC_NUMBER.

Review of attachment 8904028 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thanks.
Attachment #8904028 - Flags: review?(dteller) → review+

Comment 3

a month ago
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d76fe320d1a
Fix comment for MAGIC_NUMBER. r=Yoric
(Assignee)

Comment 4

a month ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d76fe320d1a10c903ea139296c35bde38136db8
Bug 1396398 - Fix comment for MAGIC_NUMBER. r=Yoric

Comment 5

29 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1d76fe320d1a
Status: ASSIGNED → RESOLVED
Last Resolved: 29 days ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.