Closed Bug 1396434 Opened 2 years ago Closed 2 years ago
Allow symbols to be stored as global variables
59 bytes, text/x-review-board-request
If some page uses console.log(Symbol('foo')), I should be able to right-click the symbol in the console and choose "Store as global variable". Currently it's greyed out in the new console.
This comes in 2 parts: - We are missing the `data-link-actor-id` attribute in the Symbol rep, which is what enable or not the context menu entry. - We are missing the actor reference in the Symbol packet (http://searchfox.org/mozilla-central/source/devtools/server/actors/object.js#2378-2386, which prevents us from adding the attribute).
After bug 1424722 adds symbol actors and https://github.com/devtools-html/devtools-core/pull/879 adds the `data-link-actor-id` attribute, then this test should pass.
Assignee: nobody → oriol-bugzilla
Status: NEW → ASSIGNED
Attachment #8939296 - Flags: review?(nchevobbe)
Comment on attachment 8939296 [details] Bug 1396434 - Test that symbols can be stored as global variables in the console. https://reviewboard.mozilla.org/r/209726/#review215396 Seems good to me, thanks Oriol ! Let's push to try once the new bundle lands.
Attachment #8939296 - Flags: review?(nchevobbe) → review+
Green try with rebased patch.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/4e3d7247274a Test that symbols can be stored as global variables in the console. r=nchevobbe
You need to log in before you can comment on or make changes to this bug.