1396434 - Allow symbols to be stored as global variables

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P5)

Description

[Oriol Brufau [:Oriol]]

If some page uses console.log(Symbol('foo')), I should be able to right-click the symbol in the console and choose "Store as global variable". Currently it's greyed out in the new console.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

This comes in 2 parts: 
- We are missing the `data-link-actor-id` attribute in the Symbol rep, which is what enable or not the context menu entry.
- We are missing the actor reference in the Symbol packet (http://searchfox.org/mozilla-central/source/devtools/server/actors/object.js#2378-2386, which prevents us from adding the attribute).

Comment 2

[Oriol Brufau [:Oriol]]

Attachment: Bug 1396434 - Test that symbols can be stored as global variables in the console.

Review commit: https://reviewboard.mozilla.org/r/209726/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209726/

Comment 3

[Oriol Brufau [:Oriol]]

After bug 1424722 adds symbol actors and https://github.com/devtools-html/devtools-core/pull/879 adds the `data-link-actor-id` attribute, then this test should pass.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8939296 [details]
Bug 1396434 - Test that symbols can be stored as global variables in the console.

https://reviewboard.mozilla.org/r/209726/#review215396

Seems good to me, thanks Oriol !
Let's push to try once the new bundle lands.

Comment 5

[Oriol Brufau [:Oriol]]

Comment on attachment 8939296 [details]
Bug 1396434 - Test that symbols can be stored as global variables in the console.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/209726/diff/1-2/

Comment 6

[Oriol Brufau [:Oriol]]

Green try with rebased patch.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e3d7247274a
Test that symbols can be stored as global variables in the console. r=nchevobbe

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4e3d7247274a