Closed Bug 1396434 Opened 2 years ago Closed 2 years ago

Allow symbols to be stored as global variables

Categories

(DevTools :: Console, enhancement, P5)

enhancement

Tracking

(firefox57 wontfix, firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox57 --- wontfix
firefox59 --- fixed

People

(Reporter: Oriol, Assigned: Oriol)

References

Details

Attachments

(1 file)

If some page uses console.log(Symbol('foo')), I should be able to right-click the symbol in the console and choose "Store as global variable". Currently it's greyed out in the new console.
This comes in 2 parts: 
- We are missing the `data-link-actor-id` attribute in the Symbol rep, which is what enable or not the context menu entry.
- We are missing the actor reference in the Symbol packet (http://searchfox.org/mozilla-central/source/devtools/server/actors/object.js#2378-2386, which prevents us from adding the attribute).
Priority: -- → P5
Depends on: 1424721
Depends on: 1424722
After bug 1424722 adds symbol actors and https://github.com/devtools-html/devtools-core/pull/879 adds the `data-link-actor-id` attribute, then this test should pass.
Assignee: nobody → oriol-bugzilla
Status: NEW → ASSIGNED
Attachment #8939296 - Flags: review?(nchevobbe)
Comment on attachment 8939296 [details]
Bug 1396434 - Test that symbols can be stored as global variables in the console.

https://reviewboard.mozilla.org/r/209726/#review215396

Seems good to me, thanks Oriol !
Let's push to try once the new bundle lands.
Attachment #8939296 - Flags: review?(nchevobbe) → review+
Depends on: 1427184
Green try with rebased patch.
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/4e3d7247274a
Test that symbols can be stored as global variables in the console. r=nchevobbe
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4e3d7247274a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.