Closed
Bug 1396478
Opened 5 years ago
Closed 5 years ago
Assertion failure: container (Text node having rendered text hasn't accessible document!) [@ mozilla::a11y::NotificationController::WillRefresh]
Categories
(Core :: Disability Access APIs, defect, P2)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: tsmith, Assigned: eeejay)
References
(Blocks 1 open bug)
Details
(Keywords: assertion, testcase)
Attachments
(3 files, 2 obsolete files)
330 bytes,
text/html
|
Details | |
1.97 KB,
patch
|
Details | Diff | Splinter Review | |
1.38 KB,
patch
|
RyanVM
:
review+
|
Details | Diff | Splinter Review |
Assertion failure: container (Text node having rendered text hasn't accessible document!), at src/accessible/base/NotificationController.cpp:717 #0 0x7f53e199ca3f in mozilla::a11y::NotificationController::WillRefresh(mozilla::TimeStamp) src/accessible/base/NotificationController.cpp:886:25 #1 0x7f53df27a1bb in nsRefreshDriver::Tick(long, mozilla::TimeStamp) src/layout/base/nsRefreshDriver.cpp:1886:12 #2 0x7f53df28394e in mozilla::RefreshDriverTimer::TickRefreshDrivers(long, mozilla::TimeStamp, nsTArray<RefPtr<nsRefreshDriver> >&) src/layout/base/nsRefreshDriver.cpp:307:7 #3 0x7f53df283724 in mozilla::RefreshDriverTimer::Tick(long, mozilla::TimeStamp) src/layout/base/nsRefreshDriver.cpp:328:5 #4 0x7f53df286d15 in mozilla::VsyncRefreshDriverTimer::RunRefreshDrivers(mozilla::TimeStamp) src/layout/base/nsRefreshDriver.cpp:770:5 #5 0x7f53df285db6 in mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver(mozilla::TimeStamp) src/layout/base/nsRefreshDriver.cpp:683:35 #6 0x7f53df281d27 in mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::ParentProcessVsyncNotifier::Run() src/layout/base/nsRefreshDriver.cpp:529:20 #7 0x7f53d999d96f in nsThread::ProcessNextEvent(bool, bool*) src/xpcom/threads/nsThread.cpp:1039:14 #8 0x7f53d99a2810 in NS_ProcessNextEvent(nsIThread*, bool) src/xpcom/threads/nsThreadUtils.cpp:521:10 #9 0x7f53da50f025 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) src/ipc/glue/MessagePump.cpp:97:21 #10 0x7f53da45fae7 in MessageLoop::RunInternal() src/ipc/chromium/src/base/message_loop.cc:326:10 #11 0x7f53da45f979 in MessageLoop::Run() src/ipc/chromium/src/base/message_loop.cc:299:3 #12 0x7f53ded7c6ea in nsBaseAppShell::Run() src/widget/nsBaseAppShell.cpp:158:27 #13 0x7f53e1f65d51 in nsAppStartup::Run() src/toolkit/components/startup/nsAppStartup.cpp:288:30 #14 0x7f53e20c984e in XREMain::XRE_mainRun() src/toolkit/xre/nsAppRunner.cpp:4643:22 #15 0x7f53e20cb4fa in XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) src/toolkit/xre/nsAppRunner.cpp:4807:8 #16 0x7f53e20cc3e8 in XRE_main(int, char**, mozilla::BootstrapConfig const&) src/toolkit/xre/nsAppRunner.cpp:4902:21 #17 0x4ecb68 in do_main(int, char**, char**) src/browser/app/nsBrowserApp.cpp:236:22 #18 0x4ec480 in main src/browser/app/nsBrowserApp.cpp:309:16 #19 0x7f53f893e82f in __libc_start_main /build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:291 #20 0x41e1b4 in _start (firefox+0x41e1b4)
Flags: in-testsuite?
Updated•5 years ago
|
Priority: -- → P2
Comment 1•5 years ago
|
||
Still reproduces on trunk. Goes back more than a year (which is as far back as mozregression can bisect debug builds).
Has Regression Range: --- → no
status-firefox56:
--- → wontfix
status-firefox58:
--- → fix-optional
status-firefox-esr52:
--- → wontfix
Reporter | ||
Comment 2•5 years ago
|
||
I am hitting this fairly frequently while fuzzing.
status-firefox59:
--- → affected
Comment 3•5 years ago
|
||
David, can we bump the priority on this to help unblock our fuzzers?
Flags: needinfo?(dbolter)
Comment 4•5 years ago
|
||
Eitan, do you have cycles to check this one, to figure out what's going on here? It could be related with one of text updates problems we were looking a while ago.
Flags: needinfo?(eitan)
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → eitan
Flags: needinfo?(eitan)
Assignee | ||
Comment 5•5 years ago
|
||
Attachment #8935172 -
Flags: review?(surkov.alexander)
Updated•5 years ago
|
Flags: needinfo?(dbolter)
Comment 6•5 years ago
|
||
Comment on attachment 8935172 [details] [diff] [review] Don't process text changes from nodes that were removed from doc. r?surkov Review of attachment 8935172 [details] [diff] [review]: ----------------------------------------------------------------- nice! ::: accessible/base/NotificationController.cpp @@ +655,2 @@ > NS_ASSERTION(!textAcc, > "Text node was removed but accessible is kept alive!"); please replace it on MOZ_ASSERT while you are here.
Attachment #8935172 -
Flags: review?(surkov.alexander) → review+
Assignee | ||
Comment 7•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Attachment #8935172 -
Attachment is obsolete: true
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/62ebba5a426a Don't process text changes from nodes that were removed from doc. r=surkov
Keywords: checkin-needed
Comment 9•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/62ebba5a426a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Comment 10•5 years ago
|
||
Is this something we should consider uplifting to Beta or can it ride the 59 train? Also, can the attached testcase be landed as a crashtest?
Flags: needinfo?(eitan)
Assignee | ||
Comment 11•5 years ago
|
||
Attachment #8936614 -
Flags: review?(ryanvm)
Comment 13•5 years ago
|
||
Comment on attachment 8936614 [details] [diff] [review] Add a crashtest. r?RyanVM Review of attachment 8936614 [details] [diff] [review]: ----------------------------------------------------------------- Did you forget to hg add the test?
Attachment #8936614 -
Flags: review?(ryanvm) → review-
Assignee | ||
Comment 14•5 years ago
|
||
Perhaps I forgot something earlier!
Attachment #8937727 -
Flags: review?(ryanvm)
Assignee | ||
Updated•5 years ago
|
Attachment #8936614 -
Attachment is obsolete: true
Updated•5 years ago
|
Attachment #8937727 -
Flags: review?(ryanvm) → review+
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Comment 15•5 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/47637ccbabfd Add a crashtest. r=RyanVM
Keywords: checkin-needed
Comment 16•5 years ago
|
||
Backed out changeset 47637ccbabfd (bug 1396478) for leaks on a newly-added accessability test on a CLOSED TREE https://treeherder.mozilla.org/logviewer.html#?job_id=152997513&repo=mozilla-inbound&lineNumber=63618 https://hg.mozilla.org/integration/mozilla-inbound/rev/ea133532d0535f40717f177e9eef93b1ed39c77e https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=47637ccbabfd7ded68c061e4bd2eb624e396c2de
Flags: needinfo?(ryanvm)
Updated•5 years ago
|
Flags: needinfo?(ryanvm) → needinfo?(twsmith)
Updated•5 years ago
|
Flags: needinfo?(twsmith) → needinfo?(eitan)
Updated•4 years ago
|
Assignee | ||
Updated•3 years ago
|
Flags: needinfo?(eitan)
You need to log in
before you can comment on or make changes to this bug.
Description
•