1396515 - Fix wrong && and || operators indentation

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Jean-Yves Avenard [:jya]]

Over the year, we had changed the formatting of logical expression containing || and && to go from:

if (a &&
    b)

to:
if (a
    && b)

this stemmed from a misreading of the coding style:
"Overlong expressions not joined by && and || should break so the operator starts on the second line and starts in the same column as the start of the expression in the first line. This applies to ?:, binary arithmetic operators including +, and member-of operators (in particular the . operator in JavaScript, see the Rationale)."

*not* joined by && and || is the keypard.

So all are to be broken with the operator put at the front, except && and ||

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

I think we should run `mach clang-format` before landing a patch even if it is not 100% compatible with the Gecko coding style. Btw, what is clang-format's opinion about the position of && or ||?

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1396515: Fix incorrect && and || operator placements.

Includes some side 80 columns fix.

Review commit: https://reviewboard.mozilla.org/r/175956/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175956/

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8904194 [details]
Bug 1396515: Fix incorrect && and || operator placements.

https://reviewboard.mozilla.org/r/175956/#review181170

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c884cca7be4a
Fix incorrect && and || operator placements. r=sylvestre

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c884cca7be4a