Closed Bug 1396530 Opened 7 years ago Closed 7 years ago

Search field has three different heights in the three sidebar panels

Categories

(Firefox :: Theme, defect, P1)

57 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 57
Iteration:
57.3 - Sep 19
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 - verified

People

(Reporter: filippo.mannino, Assigned: nhnt11)

References

(Depends on 1 open bug)

Details

(Keywords: regression, Whiteboard: [reserve-photon-visual])

Attachments

(3 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170903220032

Steps to reproduce:

Open Firefox Nightly 57 and show the sidebar.
Switch on the three available panels (bookmarks, history, synced tabs) and watch search field height.


Actual results:

Search field height is different in all three cases.


Expected results:

Search field height should be the same in all three cases.
Component: Untriaged → Theme
The history vs. bookmarks thing regressed when bug 1377003 removed the align=center from the sidebar-search-container. Synced tabs are a special snowflake, so I don't know how much we care about the minor difference there, but I think the Windows look of the history search isn't very nice as it is. Nihanth, can you take a look at this and/or triage as part of photon-visual?
Blocks: 1377003
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(nhnt11)
Keywords: regression
Whiteboard: [photon-visual][triage]
Flags: qe-verify+
Priority: -- → P3
QA Contact: ovidiu.boca
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Triaged by photon team, doesn't sound like this should block 57, so not tracking for relman team.
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Flags: needinfo?(nhnt11)
Iteration: --- → 57.3 - Sep 19
Priority: P3 → P1
Comment on attachment 8906960 [details]
Bug 1396530 - Update styling of View button in History sidebar and magnifying glass icon in synced tabs sidebar on Windows.

https://reviewboard.mozilla.org/r/178706/#review184336
Attachment #8906960 - Flags: review?(dao+bmo) → review+
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a0460f44dfb3
Update styling of View button in History sidebar and magnifying glass icon in synced tabs sidebar on Windows. r=dao
https://hg.mozilla.org/mozilla-central/rev/a0460f44dfb3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Problem still persists for the Synced Tabs panel.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Filippo from comment #7)
> Created attachment 8908510 [details]
> Problem still persists on 2017-09-15
> 
> Problem still persists for the Synced Tabs panel.

We only reopen bugs if patches are completely nonfunctional and/or get backed out. Please file a separate followup bug with more details (what OS and OS theme is this? Windows 7?).
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Flags: needinfo?(filippo.mannino)
Resolution: --- → FIXED
OK I'll file another bug.
Flags: needinfo?(filippo.mannino)
Depends on: 1400268
Verified as fixed on Nightly 57.0a1, Build ID 20170917220255 on Windows 10 x64.
Based on the fact that has been opened a new bug 1400268 for the sync tab i will mark this as fixed verified.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.