Closed Bug 1396538 Opened 7 years ago Closed 7 years ago

Graph shape of some discrete animation properties in detail pane are not displayed correctly.

Categories

(DevTools :: Inspector: Animations, defect)

defect
Not set
normal

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: daisuke, Assigned: daisuke)

Details

Attachments

(3 files)

Attached image background-repeat.png
As you can see in the attached screenshot, the graph shape of some properties that animate as discretely is not correct. The shape should be like stair.
For this test, I specified backgroundRepeat: ['round', 'space'] as keyframes.

The cause might be the computed value differ to specified keyframes value.
Comment on attachment 8904200 [details]
Bug 1396538 - Part 1: Use computed value as the value scale.

https://reviewboard.mozilla.org/r/175976/#review180962

::: devtools/client/animationinspector/graph-helper.js:219
(Diff revision 1)
>     *                    from given style (e.g. center)
>     */
>    getDiscreteValueHelperFunction: function () {
>      const discreteValues = [];
>      this.keyframes.forEach(keyframe => {
> -      if (!discreteValues.includes(keyframe.value)) {
> +      // Set style once since the computed value may differ to specified keyframe value.

"may differ from specified": from instead of to.
Attachment #8904200 - Flags: review?(pbrosset) → review+
Comment on attachment 8904201 [details]
Bug 1396538 - Part 2: Add test for background-repeat.

https://reviewboard.mozilla.org/r/175978/#review180964
Attachment #8904201 - Flags: review?(pbrosset) → review+
Thank you for quick review!
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ad724d3f769
Part 1: Use computed value as the value scale. r=pbro
https://hg.mozilla.org/integration/autoland/rev/f21fdf4e07a9
Part 2: Add test for background-repeat. r=pbro
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.