Closed Bug 1396578 Opened 7 years ago Closed 7 years ago

Non-mpc yellow info bar appears when upgrading non-mpc legacy add-ons to webextensions

Categories

(Toolkit :: Add-ons Manager, defect, P2)

57 Branch
defect

Tracking

()

VERIFIED FIXED
mozilla57
Tracking Status
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- verified

People

(Reporter: vtamas, Assigned: aswan)

References

Details

Attachments

(3 files)

Attached image non-mpcnotification.gif
[Affected versions]:
Firefox 57.0a1 from https://bugzilla.mozilla.org/show_bug.cgi?id=1353194#c33

[Affected platforms]:
Windows 10 64-bit
Mac OS X 10.12.3

[Steps to reproduce]:
1.Launch Firefox Release with a clean profile.
2.Install the following legacy add-ons or one of them:
 - https://addons.mozilla.org/firefox/downloads/file/539091/adblock_for_firefox-2.5.0-an+fx.xpi?src=version-history
 - https://addons.mozilla.org/firefox/downloads/file/427565/ad_blocker_ultimate-2.23-an+fx.xpi?src=version-history
 - https://addons.mozilla.org/firefox/downloads/file/467184/grammarly_for_firefox-8.646.510-fx.xpi?src=version-history
 - https://addons.mozilla.org/firefox/downloads/file/488557/react_developer_tools-0.15.3-fx.xpi?src=version-history
3.Restart the browser to complete the add-on installation.
4.Close the browser and open the same profile using the build from https://bugzilla.mozilla.org/show_bug.cgi?id=1353194#c33

 
[Expected Results]:
There is no non-mpc yellow info bar displayed considering that all the add-ons were successfully updated to a webextension version. 

[Actual Results]:
- Non-mpc yellow info bar is displayed even if there are no legacy add-ons disabled.
- See attached screencast.
Assignee: nobody → aswan
Priority: -- → P2
Attachment #8904584 - Flags: review?(rhelmer)
Comment on attachment 8904584 [details]
Bug 1396578 Remove startup notification for non-mpc extensions

https://reviewboard.mozilla.org/r/176426/#review181386

Looks like there is still a string and code for invidivual non-MPC add-ons in `content/extensions.{js,xml}`, should that be removed now too?
Attachment #8904584 - Flags: review?(rhelmer) → review+
Its still the case that we disable non-MPC extensions on Nightly if legacy extensions are disabled.  There's a separate bug to clean that up...
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/54c594c4f68c
Remove startup notification for non-mpc extensions r=rhelmer
https://hg.mozilla.org/mozilla-central/rev/54c594c4f68c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
I confirm that the yellow startup notification for non-mpc extensions is no longer displayed on Firefox 57.0a1 (20170907100318) under Windows 10 64-bit and Mac OS X 10.12.3 while upgrading from a old Firefox version with several non-mpc add-ons installed on that profile.
Status: RESOLVED → VERIFIED
Attached image 2017-09-07_1653.png
> Looks like there is still a string and code for invidivual non-MPC add-ons
> in `content/extensions.{js,xml}`, should that be removed now too?

> Its still the case that we disable non-MPC extensions on Nightly if legacy
> extensions are disabled.  There's a separate bug to clean that up...

Are you referring to the attached non-mpc warnings? I think that this warning make sense 
as long as the extensions.legacy.enabled pref can be set to true.
Flags: needinfo?(aswan)
Yes, I was referring to the warnings in the attached screenshot.
Flags: needinfo?(aswan)
You need to log in before you can comment on or make changes to this bug.