Open Bug 1396582 Opened 3 years ago Updated 2 years ago

Move verify_python_version to build/moz.configure/init.configure

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox57 wontfix)

ASSIGNED
Tracking Status
firefox57 --- wontfix

People

(Reporter: davehunt, Assigned: gps)

Details

Attachments

(2 files)

As mentioned in bug 1388013 comment 8, we'd like to move the Python version checking code from python/mozbuild/mozbuild/virtualenv.py into build/moz.configure/init.configure.
Flags: needinfo?(gps)
Blocks: 1388013
Will submit patch shortly.
Flags: needinfo?(gps)
Assignee: nobody → gps
Status: NEW → ASSIGNED
Comment on attachment 8940891 [details]
Bug 1396582 - Move Python version checking to moz.configure;

https://reviewboard.mozilla.org/r/211150/#review217184

One question, but otherwise this lgtm.

::: build/moz.configure/init.configure:226
(Diff revision 1)
>          elif 'PYTHON' in mozconfig['vars']['added']:
>              python = mozconfig['vars']['added']['PYTHON']
>          elif 'PYTHON' in mozconfig['vars']['modified']:
>              python = mozconfig['vars']['modified']['PYTHON'][1]
>  
> -    with LineIO(lambda l: log.error(l)) as out:
> +    minimum_version = Version('2.7.3')

We went from `LooseVersion` to `Version`, and I do see a direct comparison.  Explain why that doesn't change the logic, please.
Attachment #8940891 - Flags: review+
Attachment #8940891 - Flags: review?(core-build-config-reviews)
Comment on attachment 8940892 [details]
Bug 1396582 - Remove __main__ from mozbuild.virtualenv;

https://reviewboard.mozilla.org/r/211152/#review217186

Sure.  If it's green on try, it's good for me.
Attachment #8940892 - Flags: review+
Attachment #8940892 - Flags: review?(core-build-config-reviews)
Comment on attachment 8940891 [details]
Bug 1396582 - Move Python version checking to moz.configure;

https://reviewboard.mozilla.org/r/211150/#review217184

> We went from `LooseVersion` to `Version`, and I do see a direct comparison.  Explain why that doesn't change the logic, please.

`Version` in moz.configure land is a magic global symbol. It is a subtype of `LooseVersion`. So functionality didn't change here.
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e81669959ed
Move Python version checking to moz.configure; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/a677efcd8768
Remove __main__ from mozbuild.virtualenv; r=nalexander
Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79a6260e52a7
Backed out 2 changesets for build bustage "ImportError: No module named which". r=backout a=backout  on a CLOSED TREE
Product: Core → Firefox Build System
No longer blocks: 1388013

(In reply to Pulsebot from comment #8)

Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79a6260e52a7
Backed out 2 changesets for build bustage "ImportError: No module named
which". r=backout a=backout on a CLOSED TREE

That error: ImportError: No module named which
is what I get when I change this modconfig line:
mk_add_options MOZ_OBJDIR=/tmp/obj-@CONFIG_GUESS@
into this line:
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-@CONFIG_GUESS@

tested on HEAD which is:
changeset: 453863:a559b84032a8
tag: tip
user: Cosmin Sabou <csabou@mozilla.com>
date: Tue Jan 15 12:38:06 2019 +0200
summary: Backed out changeset dad40f23f4c1 (bug 1519617) for breaking Soundcloud. a=backout

<details><summary>Full output:</summary>

==> Starting build()...
BUILDENV=([0]="!distcc" [1]="color" [2]="ccache" [3]="check" [4]="!sign")
build_options=([0]="ccache" [1]="distcc" [2]="buildflags" [3]="makeflags")
i='!distcc'
options=([0]="!strip" [1]="!debug" [2]="!ccache" [3]="!distcc")
    set | grep -i distcc;
    if check_buildoption "distcc" "y"; then
        if ! type -p distcc > /dev/null; then
            error "$(gettext "Cannot find the %s binary required for distributed compilation.")" "distcc";
    local string=(CARCH CHOST CPPFLAGS CFLAGS CXXFLAGS LDFLAGS DEBUG_CFLAGS DEBUG_CXXFLAGS DISTCC_HOSTS BUILDDIR STRIP_BINARIES STRIP_SHARED STRIP_STATIC PKGDEST SRCDEST SRCPKGDEST LOGDEST PACKAGER GPGKEY PKGEXT SRCEXT);
    if check_buildoption "distcc" "y"; then
            export CCACHE_PREFIX="${CCACHE_PREFIX:+$CCACHE_PREFIX }distcc";
            if [[ -d /usr/lib/distcc/bin ]]; then
                export PATH="/usr/lib/distcc/bin:$PATH";
        export DISTCC_HOSTS;
/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/testing/mozbase/mozsystemmonitor/mozsystemmonitor/resourcemonitor.py:266: UserWarning: psutil failed to run: not sure how to interpret line '   8       0 sda 1733779 470104 109453984 2671991 831598 409741 93066128 8392785 0 1385760 10212954 852638 0 73276328 203415\n'
  warnings.warn('psutil failed to run: %s' % e)
 /home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/obj-x86_64-pc-linux-gnu/config.status is out of date with respect to /home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/build/moz.configure/init.configure
 0:00.80 Clobber not needed.
 0:00.80 Adding make options from /home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/mozconfig
    AUTOCONF=autoconf-2.13
    PYTHON=/usr/bin/python2
    MOZ_MAKE_FLAGS=-j5
    MOZ_OBJDIR=/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/obj-x86_64-pc-linux-gnu
    OBJDIR=/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/obj-x86_64-pc-linux-gnu
    FOUND_MOZCONFIG=/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/mozconfig
    export FOUND_MOZCONFIG
 0:00.81 /usr/bin/make -f client.mk MOZ_PARALLEL_BUILD=5 -s configure
 0:00.81 Environment: {'HISTTIMEFORMAT': '%F %T ', 'GOOGLE_CLOUD_SDK_HOME': '/opt/google-cloud-sdk', 'LESS': '-+X -R -+S -+F -+E -I -M --shift 5', 'XDG_SESSION_TYPE': 'tty', 'CLOUDSDK_PYTHON_ARGS': '-S', 'SHELL': '/bin/bash', 'GIT_SSH': '/home/xftroxgpx/bin/sshgit', 'HISTSIZE': '-1', 'TEXTDOMAIN': 'pacman-scripts', u'OBJDIR': u'/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/obj-x86_64-pc-linux-gnu', 'INVOCATION_ID': '3385c77990ad449f81e6fc428540cc66', 'XDG_RUNTIME_DIR': '/run/user/1000', 'CCACHE_NOCOMPRESS': '1', 'FREETYPE_PROPERTIES': 'truetype:interpreter-version=38', 'RUST_SRC_PATH': '/home/xftroxgpx/build/2nonpkgs/rust.stuff/rust/rust/src', 'XDG_SESSION_ID': 'c1', 'DBUS_SESSION_BUS_ADDRESS': 'unix:abstract=/tmp/dbus-slPM1vYtxk,guid=bcaea5cede228b7a9e73dd945c3cc64b', 'LESS_TERMCAP_ue': '\x1b[0m', 'MOZ_PLUGIN_PATH': '/14918', 'MY_GIT_USERNAME': 'xftroxgpx', 'HISTFILESIZE': '-1', 'XZ_DEFAULTS': '--threads=0', 'MACH_MAIN_PID': '3161', 'MAIL': '/var/spool/mail/xftroxgpx', 'LS_COLORS': 'rs=0:di=01;34:ln=01;36:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:mi=00:su=37;41:sg=30;43:ca=30;41:tw=30;42:ow=34;42:st=37;44:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arc=01;31:*.arj=01;31:*.taz=01;31:*.lha=01;31:*.lz4=01;31:*.lzh=01;31:*.lzma=01;31:*.tlz=01;31:*.txz=01;31:*.tzo=01;31:*.t7z=01;31:*.zip=01;31:*.z=01;31:*.dz=01;31:*.gz=01;31:*.lrz=01;31:*.lz=01;31:*.lzo=01;31:*.xz=01;31:*.zst=01;31:*.tzst=01;31:*.bz2=01;31:*.bz=01;31:*.tbz=01;31:*.tbz2=01;31:*.tz=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.war=01;31:*.ear=01;31:*.sar=01;31:*.rar=01;31:*.alz=01;31:*.ace=01;31:*.zoo=01;31:*.cpio=01;31:*.7z=01;31:*.rz=01;31:*.cab=01;31:*.wim=01;31:*.swm=01;31:*.dwm=01;31:*.esd=01;31:*.jpg=01;35:*.jpeg=01;35:*.mjpg=01;35:*.mjpeg=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.png=01;35:*.svg=01;35:*.svgz=01;35:*.mng=01;35:*.pcx=01;35:*.mov=01;35:*.mpg=01;35:*.mpeg=01;35:*.m2v=01;35:*.mkv=01;35:*.webm=01;35:*.ogm=01;35:*.mp4=01;35:*.m4v=01;35:*.mp4v=01;35:*.vob=01;35:*.qt=01;35:*.nuv=01;35:*.wmv=01;35:*.asf=01;35:*.rm=01;35:*.rmvb=01;35:*.flc=01;35:*.avi=01;35:*.fli=01;35:*.flv=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:*.yuv=01;35:*.cgm=01;35:*.emf=01;35:*.ogv=01;35:*.ogx=01;35:*.aac=00;36:*.au=00;36:*.flac=00;36:*.m4a=00;36:*.mid=00;36:*.midi=00;36:*.mka=00;36:*.mp3=00;36:*.mpc=00;36:*.ogg=00;36:*.ra=00;36:*.wav=00;36:*.oga=00;36:*.opus=00;36:*.spx=00;36:*.xspf=00;36:', 'GOPATH': '/home/xftroxgpx/build/2nonpkgs/go.stuff/gopath', 'USER': 'xftroxgpx', 'PROMPT_COMMAND': '__earlyec=("${PIPESTATUS[@]}")', 'XDG_VTNR': '1', 'MC_PS1': '\\W \\$ ', 'HG': '/usr/bin/hg', 'PS4': '$0:$LINENO+ ', 'HTTP_USER_AGENT': 'Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0 (Chrome)', u'CONFIG_GUESS': 'x86_64-pc-linux-gnu', 'XAUTHORITY': '/home/xftroxgpx/.Xauthority', 'JOURNAL_STREAM': '9:4629', 'SESSION_MANAGER': 'local/z5:@/tmp/.ICE-unix/827,unix/z5:/tmp/.ICE-unix/827', 'SHLVL': '8', 'CLOUDSDK_PYTHON': 'python2', 'DISPLAY': ':0.0', 'WINDOWID': '18874371', 'CHOST': 'x86_64-pc-linux-gnu', 'EDITOR': 'vim', 'CCACHE_SLOPPINESS': 'include_file_mtime,file_stat_matches,include_file_ctime', 'LESS_TERMCAP_us': '\x1b[04;38;5;200m', 'LANG': 'en_US.UTF-8', 'GIT_NO_REPLACE_OBJECTS': '1', 'CFG_DISABLE_CROSS_TESTS': '1', 'GTK2_RC_FILES': '/home/xftroxgpx/.gtkrc-2.0', 'TMPDIR': '/tmp', 'CCACHE_BASEDIR': '/home/xftroxgpx/build/', 'CCACHE_NOHASHDIR': '1', 'COLORTERM': 'truecolor', 'PAGER': 'less', 'CONFIGURE_ARGS': '', 'COMMAND_MODE': 'legacy', 'CXXFLAGS': '-pipe -march=native -Wno-trigraphs -fno-schedule-insns2 -fno-delete-null-pointer-checks -mtune=native -fomit-frame-pointer -Ofast -fno-fast-math -D_FORTIFY_SOURCE=2 -mindirect-branch=thunk -mindirect-branch-register', 'RUST_BACKTRACE': '0', 'CLOUDSDK_ROOT_DIR': '/opt/google-cloud-sdk', 'HOME': '/home/xftroxgpx', 'LD_LIBRARY_PATH': '/home/xftroxgpx/build/2nonpkgs/rust.stuff/rust/rust/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib:/home/xftroxgpx/build/2nonpkgs/rust.stuff/rust/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib:/home/xftroxgpx/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib:/home/xftroxgpx/build/2nonpkgs/rust.stuff/rust/rust/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib:/home/xftroxgpx/build/2nonpkgs/rust.stuff/rust/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib:/home/xftroxgpx/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib:', 'FUNCNEST': '30000', 'XFWM4_LOG_FILE': '/tmp/xfwm4-debug-%d.log', 'MY_GIT_EMAILADDRESS': 'xftroxgpx@protonmail.com', 'VTE_VERSION': '5403', 'YAOURT_COLORS': 'nb=1:pkg=1:ver=1;32:lver=1;45:installed=1;42:grp=1;34:od=1;41;5:votes=1;44:dsc=0:other=1;35', 'GIT_PAGER': 'less', 'MOZBUILD_STATE_PATH': '/tmp/.mozbuild', 'CSCOPE_DB': '/home/xftroxgpx/cscope/', 'MOZ_MAKE_FLAGS': '-j4', 'PYTHON': '/usr/bin/python2', u'TOPSRCDIR': '/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg', 'LOGNAME': 'xftroxgpx', 'XDG_SEAT': 'seat0', 'PATH': '/opt/google-cloud-sdk/bin:/opt/google-cloud-sdk/bin:/usr/local/sbin:/usr/local/bin:/usr/bin:/opt/depot_tools:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/home/xftroxgpx/bin:/home/xftroxgpx/build/2nonpkgs/rust.stuff/racer/target/release:/home/xftroxgpx/build/2nonpkgs/rust.stuff/chars/target/debug:/home/xftroxgpx/build/2nonpkgs/rust.stuff/chars/target/release:/home/xftroxgpx/build/2nonpkgs/rust.stuff/rustfmt/target/release:/home/xftroxgpx/.cargo/bin:/opt/depot_tools:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/home/xftroxgpx/bin:/home/xftroxgpx/build/2nonpkgs/rust.stuff/racer/target/release:/home/xftroxgpx/build/2nonpkgs/rust.stuff/chars/target/debug:/home/xftroxgpx/build/2nonpkgs/rust.stuff/chars/target/release:/home/xftroxgpx/build/2nonpkgs/rust.stuff/rustfmt/target/release:/home/xftroxgpx/.cargo/bin', 'MAKEFLAGS': '-j4', 'SSH_AGENT_PID': '870', 'LESS_TERMCAP_se': '\x1b[0m', 'TERM': 'xterm-256color', 'LESS_TERMCAP_me': '\x1b[0m', 'LESS_TERMCAP_md': '\x1b[01;38;5;75m', 'LESS_TERMCAP_mb': '\x1b[01;31m', 'WINDOWPATH': '1', 'LDFLAGS': '-Wl,-O1,--sort-common,--as-needed,-z,relro -Wl,-rpath,/usr/lib/firefox', 'SOURCE_DATE_EPOCH': '1547551973', 'XDG_SESSION_CLASS': 'user', 'PROMPT_DIRTRIM': '2', 'CFLAGS': '-pipe -march=native -Wno-trigraphs -fno-schedule-insns2 -fno-delete-null-pointer-checks -mtune=native -fomit-frame-pointer -Ofast -fno-fast-math -D_FORTIFY_SOURCE=2 -mindirect-branch=thunk -mindirect-branch-register', 'SSH_AUTH_SOCK': '/tmp/ssh-MWTD8JfY4Dc5/agent.869', 'TEXTDOMAINDIR': '/usr/share/locale', 'MACH_STDOUT_ISATTY': '1', 'MACH': u'1', 'DONT_MOUNT_BOOT': '1', 'OLDPWD': '/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src', 'HISTCONTROL': 'ignorespace', 'PWD': '/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg', 'XZ_OPT': '--threads=0', 'LESS_TERMCAP_so': '\x1b[01;33m', 'NINJA_STATUS': '\n\x1b[42m[%u/%r/%f/%t] %es\x1b(B\x1b[m [remaining/running/finished/totalthissession] elapsed\n\x1b];[%u/%r/%f/%t] %es [remaining/running/finished/totalthissession] elapsed\x07'}
 0:00.83 cd /home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/obj-x86_64-pc-linux-gnu
 0:00.83 /home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/configure
 0:01.38 Reexecuting in the virtualenv
 0:01.76 Adding configure options from /home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/mozconfig
 0:01.76   --enable-application=browser
 0:01.76   --enable-application=browser
 0:01.76   --enable-optimize
 0:01.76   --enable-more-deterministic
 0:01.76   --disable-debug
 0:01.76   --disable-install-strip
 0:01.76   --disable-strip
 0:01.76   --enable-debug-symbols
 0:01.76   --disable-tests
 0:01.76   --disable-debug-js-modules
 0:01.76   --prefix=/usr
 0:01.77   --without-system-nspr
 0:01.77   --without-system-nss
 0:01.77   --with-system-jpeg
 0:01.77   --with-system-zlib
 0:01.77   --with-system-bz2
 0:01.77   --with-system-png
 0:01.77   --with-system-libevent
 0:01.77   --with-system-libvpx
 0:01.77   --enable-system-sqlite
 0:01.77   --enable-system-ffi
 0:01.77   --disable-crashreporter
 0:01.77   --disable-updater
 0:01.77   --disable-update-channel
 0:01.77   --disable-profiling
 0:01.77   --disable-valgrind
 0:01.77   --disable-jprof
 0:01.77   --disable-instruments
 0:01.77   --disable-callgrind
 0:01.77   --disable-vtune
 0:01.77   --disable-cpp-rtti
 0:01.77   --enable-gold
 0:01.77   --disable-dtrace
 0:01.77   --enable-printing
 0:01.77   --disable-libproxy
 0:01.77   --disable-dbus
 0:01.77   --disable-dbm
 0:01.77   --disable-accessibility
 0:01.77   --disable-webrtc
 0:01.77   --disable-raw
 0:01.77   --disable-directshow
 0:01.77   --disable-wmf
 0:01.77   --enable-ffmpeg
 0:01.77   --enable-fmp4
 0:01.77   --disable-eme
 0:01.77   --disable-alsa
 0:01.77   --enable-pulseaudio
 0:01.77   --disable-system-extension-dirs
 0:01.77   --enable-extensions=default,-skipgnomevfs,-skipgio
 0:01.77   --disable-verify-mar
 0:01.77   --disable-signmar
 0:01.77   --disable-parental-controls
 0:01.77   --enable-sandbox
 0:01.77   --enable-content-sandbox
 0:01.77   --enable-zipwriter
 0:01.77   --disable-logrefcnt
 0:01.77   --disable-dump-painting
 0:01.77   --disable-tasktracer
 0:01.77   --disable-stdcxx-compat
 0:01.77   --disable-startupcache
 0:01.77   --disable-nfc
 0:01.77   --disable-webspeech
 0:01.77   --disable-synth-pico
 0:01.77   --disable-system-cairo
 0:01.78   --disable-system-pixman
 0:01.78   --enable-xul
 0:01.78   --disable-necko-wifi
 0:01.78   --enable-ctypes
 0:01.78   --with-system-icu
 0:01.78   --with-intl-api
 0:01.78   --with-ccache=/usr/bin/ccache
 0:01.78   MOZ_ADDON_SIGNING=1
 0:01.78   MOZ_REQUIRE_SIGNING=0
 0:01.78   CXXFLAGS=-pipe -march=native -Wno-trigraphs -fno-schedule-insns2 -fno-delete-null-pointer-checks -mtune=native -fomit-frame-pointer -Ofast -fno-fast-math -D_FORTIFY_SOURCE=2 -mno-avx -fPIC -mretpoline
 0:01.78   CFLAGS=-pipe -march=native -Wno-trigraphs -fno-schedule-insns2 -fno-delete-null-pointer-checks -mtune=native -fomit-frame-pointer -Ofast -fno-fast-math -D_FORTIFY_SOURCE=2 -fPIC -mretpoline
 0:01.78   BASH_ARGC=([0]="4")
 0:01.78   BASH_ARGV=([0]="/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/action/dump_env.py" [1]="/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/obj-x86_64-pc-linux-gnu/_virtualenvs/init/bin/python" [2]="/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/mozconfig" [3]="/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg")
 0:01.78 checking for vcs source checkout... hg
 0:02.22 checking for a shell... Traceback (most recent call last):
 0:02.22   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/configure.py", line 123, in <module>
 0:02.22     sys.exit(main(sys.argv))
 0:02.22   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/configure.py", line 29, in main
 0:02.22     sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
 0:02.22   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 425, in run
 0:02.22     self.include_file(path)
 0:02.22   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 416, in include_file
 0:02.22     exec_(code, self)
 0:02.22   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/util.py", line 59, in exec_
 0:02.22     exec(object, globals, locals)
 0:02.22   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/moz.configure", line 241, in <module>
 0:02.22     include(include_project_configure)
 0:02.22   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 719, in include_impl
 0:02.22     self.include_file(what)
 0:02.22   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 416, in include_file
 0:02.22     exec_(code, self)
 0:02.22   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/util.py", line 59, in exec_
 0:02.22     exec(object, globals, locals)
 0:02.22   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/browser/moz.configure", line 20, in <module>
 0:02.22     include('../toolkit/moz.configure')
 0:02.22   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 719, in include_impl
 0:02.22     self.include_file(what)
 0:02.22   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 416, in include_file
 0:02.22     exec_(code, self)
 0:02.22   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/util.py", line 59, in exec_
 0:02.22     exec(object, globals, locals)
 0:02.22   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/toolkit/moz.configure", line 103, in <module>
 0:02.22     help='{Enable|Disable} PulseAudio audio backend.')
 0:02.22   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 637, in option_impl
 0:02.22     kwargs = {k: self._resolve(v) for k, v in kwargs.iteritems()
 0:02.22   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 638, in <dictcomp>
 0:02.22     if k != 'when'}
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 492, in _resolve
 0:02.23     return self._value_for_depends(self._depends[arg])
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/util.py", line 944, in method_call
 0:02.23     cache[args] = self.func(instance, *args)
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 510, in _value_for_depends
 0:02.23     return obj.result()
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/util.py", line 944, in method_call
 0:02.23     cache[args] = self.func(instance, *args)
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 146, in result
 0:02.23     for d in self.dependencies]
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 501, in _value_for
 0:02.23     return self._value_for_depends(obj)
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/util.py", line 944, in method_call
 0:02.23     cache[args] = self.func(instance, *args)
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 510, in _value_for_depends
 0:02.23     return obj.result()
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/util.py", line 944, in method_call
 0:02.23     cache[args] = self.func(instance, *args)
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 223, in result
 0:02.23     return self._func(resolved_args)
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 169, in or_impl
 0:02.23     for i in iterable:
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 222, in <genexpr>
 0:02.23     for d in self.dependencies)
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 501, in _value_for
 0:02.23     return self._value_for_depends(obj)
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/util.py", line 944, in method_call
 0:02.23     cache[args] = self.func(instance, *args)
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 510, in _value_for_depends
 0:02.23     return obj.result()
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/util.py", line 944, in method_call
 0:02.23     cache[args] = self.func(instance, *args)
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 146, in result
 0:02.23     for d in self.dependencies]
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 501, in _value_for
 0:02.23     return self._value_for_depends(obj)
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/util.py", line 944, in method_call
 0:02.23     cache[args] = self.func(instance, *args)
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 510, in _value_for_depends
 0:02.23     return obj.result()
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/util.py", line 944, in method_call
 0:02.23     cache[args] = self.func(instance, *args)
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 223, in result
 0:02.23     return self._func(resolved_args)
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 169, in or_impl
 0:02.23     for i in iterable:
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 222, in <genexpr>
 0:02.23     for d in self.dependencies)
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 501, in _value_for
 0:02.23     return self._value_for_depends(obj)
 0:02.23   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/util.py", line 944, in method_call
 0:02.23     cache[args] = self.func(instance, *args)
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 510, in _value_for_depends
 0:02.24     return obj.result()
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/util.py", line 944, in method_call
 0:02.24     cache[args] = self.func(instance, *args)
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 146, in result
 0:02.24     for d in self.dependencies]
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 501, in _value_for
 0:02.24     return self._value_for_depends(obj)
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/util.py", line 944, in method_call
 0:02.24     cache[args] = self.func(instance, *args)
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 510, in _value_for_depends
 0:02.24     return obj.result()
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/util.py", line 944, in method_call
 0:02.24     cache[args] = self.func(instance, *args)
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 147, in result
 0:02.24     return self._func(*resolved_args)
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 1027, in wrapped
 0:02.24     return new_func(*args, **kwargs)
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 760, in wrapper
 0:02.24     ret = template(*args, **kwargs)
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/build/moz.configure/checks.configure", line 58, in wrapped
 0:02.24     ret = func(*args, **kwargs)
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 1027, in wrapped
 0:02.24     return new_func(*args, **kwargs)
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/build/moz.configure/init.configure", line 363, in shell
 0:02.24     return find_program(shell)
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 1026, in wrapped
 0:02.24     self._apply_imports(func, glob)
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 825, in _apply_imports
 0:02.24     glob[what] = self._get_one_import('%s%s' % (_from, what))
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/configure/__init__.py", line 845, in _get_one_import
 0:02.24     exec_(import_line, {}, glob)
 0:02.24   File "/home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/python/mozbuild/mozbuild/util.py", line 59, in exec_
 0:02.24     exec(object, globals, locals)
 0:02.24   File "<string>", line 1, in <module>
 0:02.24 ImportError: No module named which
 0:02.28 *** Fix above errors and then restart with\
 0:02.28                "./mach build"
 0:02.28 make: *** [client.mk:115: configure] Error 1
/home/xftroxgpx/build/1packages/4used/firefox-hg/PKGBUILD: line 224: kill: (2732) - No such process
==> ERROR: A failure occurred in build().
    Aborting...

real	0m8.714s
user	0m6.500s
sys	0m2.326s

</details>

(In reply to xftroxgpx from comment #9)

(In reply to Pulsebot from comment #8)

Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79a6260e52a7
Backed out 2 changesets for build bustage "ImportError: No module named
which". r=backout a=backout on a CLOSED TREE

That error: ImportError: No module named which
is what I get when I change this modconfig line:
mk_add_options MOZ_OBJDIR=/tmp/obj-@CONFIG_GUESS@
into this line:
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-@CONFIG_GUESS@

I "fixed" it by removing the obj dir which for me was: /home/xftroxgpx/build/1packages/4used/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/obj-x86_64-pc-linux-gnu/. I realized this was needed because making a symlink to it from /tmp while using the original MOZ_OBJDIR line that didn't err, still ended up error-ing! So the culprit was obvious then, since a clean objdir yielded no error!

So i guess moving the old obj dir (from /tmp) into the new location(under @TOPSRCDIR@) is a no no :)

0:08.02 checking for a shell... /usr/bin/sh

You need to log in before you can comment on or make changes to this bug.