Closed Bug 1396586 Opened 7 years ago Closed 7 years ago

Stop escaping U+0080 to U+009F in CSS serialization

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: SimonSapin, Assigned: SimonSapin)

Details

Attachments

(1 file)

Bug 229827 comment 7 said:

> Well, U+0080 through U+009F are identifier characters in CSS so they don't have to be escaped, but it's probably reasonable to escape them given that they've now been assigned and they're nonprintable.

However https://drafts.csswg.org/cssom/#serialize-an-identifier specified that all non-ASCII code points are to be serialized as themselves. Additionally, Stylo implements this by traversing an UTF-8 string where it is simpler (and possibly slightly more efficient) to work at the bytes level and copy all non-ASCII bytes unchanged.

https://github.com/servo/servo/pull/18355 makes this change for CSS parsing error messages in Stylo. This bug is for updating the test expectations and changing the behavior of the C++ style system to match. Both should land together.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae3142267644b161404c08fb6631fb8eb9d53f36 is a try run with the code changes but no test expectation changes.
Comment on attachment 8904262 [details]
Bug 1396586 - Stop escaping U+0080 to U+009F in CSS serialization.

https://reviewboard.mozilla.org/r/176036/#review181042

r=me, with maybe a bit more context in the commit message (though I feel like Gecko people usually also refer to the bug itself).
Attachment #8904262 - Flags: review?(emilio) → review+
Pushed by simon.sapin@exyr.org:
https://hg.mozilla.org/integration/autoland/rev/8f120e9b0a45
Stop escaping U+0080 to U+009F in CSS serialization. r=emilio
https://hg.mozilla.org/mozilla-central/rev/8f120e9b0a45
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee: nobody → simon.sapin
You need to log in before you can comment on or make changes to this bug.