1396629 - Show container type in media debug

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Jean-Yves Avenard [:jya]]

In bug 1394591 we added the codec type used per video tracks.

We could also show the container type, as well as the container type for each sourcebuffer.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1396629 - P1. Use nsCString.

The default string is over 400 bytes long, it will never fit in the default 64 bytes buffer of an nsAutoCString.

Review commit: https://reviewboard.mozilla.org/r/176158/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176158/

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1396629 - P2. Change string type.

Review commit: https://reviewboard.mozilla.org/r/176160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176160/

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1396629 - P3. Make member const.

Review commit: https://reviewboard.mozilla.org/r/176162/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176162/

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1396629 - P4. Show sourcebuffer mimetype in debug info.

Review commit: https://reviewboard.mozilla.org/r/176164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176164/

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1396629 - P5. Show container type in debug info.

Review commit: https://reviewboard.mozilla.org/r/176166/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176166/

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8904358 [details]
Bug 1396629 - P1. Use nsCString.

https://reviewboard.mozilla.org/r/176158/#review181556

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8904359 [details]
Bug 1396629 - P2. Change string type.

https://reviewboard.mozilla.org/r/176160/#review181558

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8904360 [details]
Bug 1396629 - P3. Make member const.

https://reviewboard.mozilla.org/r/176162/#review181560

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8904361 [details]
Bug 1396629 - P4. Show sourcebuffer mimetype in debug info.

https://reviewboard.mozilla.org/r/176164/#review181562

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8904362 [details]
Bug 1396629 - P5. Show container type in debug info.

https://reviewboard.mozilla.org/r/176166/#review181566

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3730187f0b9b
P1. Use nsCString. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/26d57c1276f3
P2. Change string type. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/785ea30fc861
P3. Make member const. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/27586b1f736b
P4. Show sourcebuffer mimetype in debug info. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/8061d34e7d21
P5. Show container type in debug info. r=cpearce

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3730187f0b9b
https://hg.mozilla.org/mozilla-central/rev/26d57c1276f3
https://hg.mozilla.org/mozilla-central/rev/785ea30fc861
https://hg.mozilla.org/mozilla-central/rev/27586b1f736b
https://hg.mozilla.org/mozilla-central/rev/8061d34e7d21