Closed
Bug 1396654
Opened 7 years ago
Closed 7 years ago
browser_UsageTelemetry_content_aboutHome.js is going to permafail when Gecko 57 merges to Beta on 2017-09-14
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
VERIFIED
FIXED
Firefox 57
People
(Reporter: RyanVM, Assigned: Mardak)
References
Details
Attachments
(1 file)
[Tracking Requested - why for this release]: Permafailing test on the next merge day. https://treeherder.mozilla.org/logviewer.html#?job_id=128346859&repo=try TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_UsageTelemetry_content_aboutHome.js | Uncaught exception - TypeError: searchInput is null The patch below should be sufficient to reproduce the build configuration this bug was discovered in. https://hg.mozilla.org/try/rev/bcc7ddbd7ecc26a82e40df1ddff1d7bef63c8afc
Flags: needinfo?(andrei.br92)
Assignee | ||
Comment 1•7 years ago
|
||
This is because currently activity stream only is enabled by default on Nightly. The plan is to turn on activity stream by default for all channels. https://searchfox.org/mozilla-central/source/browser/app/profile/firefox.js#1285-1290 I suppose we can just make this bug the one that turns on activity stream by default.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(edilee)
Reporter | ||
Comment 3•7 years ago
|
||
Comment on attachment 8904379 [details] Bug 1396654 - Enable Activity Stream by default for all channels. Looks good on Try!
Attachment #8904379 -
Flags: feedback+
Assignee | ||
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8904379 [details] Bug 1396654 - Enable Activity Stream by default for all channels. https://reviewboard.mozilla.org/r/176180/#review182294 Mossop, anything we should wait for before turning on activity stream by default?
Assignee | ||
Updated•7 years ago
|
Attachment #8904379 -
Flags: review?(dtownsend)
Reporter | ||
Comment 5•7 years ago
|
||
Per Sylvestre's email that went out to various lists today, a week from today is when the first merge of 57 to Beta will now be happening.
Summary: browser_UsageTelemetry_content_aboutHome.js is going to permafail when Gecko 57 merges to Beta on 2017-09-20 → browser_UsageTelemetry_content_aboutHome.js is going to permafail when Gecko 57 merges to Beta on 2017-09-14
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8904379 [details] Bug 1396654 - Enable Activity Stream by default for all channels. https://reviewboard.mozilla.org/r/176180/#review182394
Attachment #8904379 -
Flags: review?(dtownsend) → review+
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/2e5bb7e3c040 Enable Activity Stream by default for all channels. r=mossop
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2e5bb7e3c040
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Reporter | ||
Updated•7 years ago
|
Updated•7 years ago
|
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•