Closed
Bug 1396693
Opened 7 years ago
Closed 7 years ago
Make nsIEventListenerChange::changedListenerNames noscript
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
2.75 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
I'm in the process of deCOMtaminating nsIAtom, and this is the last remaining use of nsIAtom from script.
Assignee | ||
Comment 1•7 years ago
|
||
This is required for deCOMtamination of nsIAtom. The patch removes the only script use of this attribute, which is a low-importance one in a test.
Attachment #8904393 -
Flags: review?(bugs)
Comment 2•7 years ago
|
||
Comment on attachment 8904393 [details] [diff] [review] Make nsIEventListenerChange::changedListenerNames noscript I guess fine, though since the whole EventListenerService is a thing for devtools, removing changedListenerNames should be ok too, if it isn't used at all. And it isn't nice to have some totally untested API available... so yes, better to remove it. With removal, including the implementation of the attribute, r+
Attachment #8904393 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 3•7 years ago
|
||
I didn't remove it because there's one use in a11y C++ code: http://searchfox.org/mozilla-central/source/accessible/base/nsAccessibilityService.cpp#317
Comment 4•7 years ago
|
||
oh. Odd, searchfox didn't show me that usage when I was looking for changedListenerNames. Ok, then don't remove.
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5616f7dc81a9 Make nsIEventListenerChange::changedListenerNames noscript. r=smaug.
Assignee | ||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5616f7dc81a947955bb8391def67a37ce9ea123a Bug 1396693 - Make nsIEventListenerChange::changedListenerNames noscript. r=smaug.
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5616f7dc81a9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•