I'm in the process of deCOMtaminating nsIAtom, and this is the last remaining use of nsIAtom from script.
Created attachment 8904393 [details] [diff] [review] Make nsIEventListenerChange::changedListenerNames noscript This is required for deCOMtamination of nsIAtom. The patch removes the only script use of this attribute, which is a low-importance one in a test.
Attachment #8904393 - Flags: review?(bugs)
Comment on attachment 8904393 [details] [diff] [review] Make nsIEventListenerChange::changedListenerNames noscript I guess fine, though since the whole EventListenerService is a thing for devtools, removing changedListenerNames should be ok too, if it isn't used at all. And it isn't nice to have some totally untested API available... so yes, better to remove it. With removal, including the implementation of the attribute, r+
Attachment #8904393 - Flags: review?(bugs) → review+
I didn't remove it because there's one use in a11y C++ code: http://searchfox.org/mozilla-central/source/accessible/base/nsAccessibilityService.cpp#317
oh. Odd, searchfox didn't show me that usage when I was looking for changedListenerNames. Ok, then don't remove.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5616f7dc81a9 Make nsIEventListenerChange::changedListenerNames noscript. r=smaug.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5616f7dc81a947955bb8391def67a37ce9ea123a Bug 1396693 - Make nsIEventListenerChange::changedListenerNames noscript. r=smaug.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.