Closed
Bug 1396694
Opened 7 years ago
Closed 7 years ago
Replace nsIAtom.idl with nsIAtom.h
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(2 files)
3.58 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
12.11 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Another step in nsIAtom's deCOMtamination, possible once all script uses of nsIAtom are removed.
Assignee | ||
Updated•7 years ago
|
Summary: Replace nsIAtom.idl to nsIAtom.h → Replace nsIAtom.idl with nsIAtom.h
Assignee | ||
Comment 1•7 years ago
|
||
This also lets us remove a couple of IDL methods.
Attachment #8904426 -
Flags: review?(nfroyd)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•7 years ago
|
||
Now that nsIAtom is non-scriptable, a .idl file isn't needed. I made the new nsIAtom.h file by starting with a generated nsIAtom.h file, and then cleaning it up and removing some stuff that wasn't necessary.
Attachment #8904427 -
Flags: review?(nfroyd)
Assignee | ||
Comment 3•7 years ago
|
||
Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=12d664440b61e7c8fb9ba7aad28042ee892285d6
Updated•7 years ago
|
Attachment #8904426 -
Flags: review?(nfroyd) → review+
Updated•7 years ago
|
Attachment #8904427 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/60ac0fadec3127895fa37fe392f4981f4fa75105 Bug 1396694 (part 1) - Make nsIAtom non-scriptable. r=froydnj. https://hg.mozilla.org/integration/mozilla-inbound/rev/15c449b14ea25a11bed7b9f5620c607aa7a3702b Bug 1396694 (part 2) - Replace nsIAtom.idl with nsIAtom.h. r=froydnj.
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/60ac0fadec31 https://hg.mozilla.org/mozilla-central/rev/15c449b14ea2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•