Closed
Bug 1396723
Opened 7 years ago
Closed 7 years ago
Use DoublyLinkedList in mozjemalloc
Categories
(Core :: Memory Allocator, enhancement)
Core
Memory Allocator
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files)
No description provided.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8904433 [details] Bug 1396723 - Simplify the trait users of DoublyLinkedList need to define. https://reviewboard.mozilla.org/r/176278/#review181912 Makes sense to me.
Attachment #8904433 -
Flags: review?(nfroyd) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8904434 [details] Bug 1396723 - Use DoublyLinkedList in mozjemalloc. https://reviewboard.mozilla.org/r/176280/#review181914
Attachment #8904434 -
Flags: review?(nfroyd) → review+
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/6ca94a450b81 Simplify the trait users of DoublyLinkedList need to define. r=froydnj https://hg.mozilla.org/integration/autoland/rev/1c0f9d069ade Use DoublyLinkedList in mozjemalloc. r=froydnj
Backed out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=129049166&repo=autoland https://hg.mozilla.org/integration/autoland/rev/bc13c43f67712786325bdea324246bea41a0b076
Flags: needinfo?(mh+mozilla)
Assignee | ||
Comment 9•7 years ago
|
||
Yay a GCC bug that I didn't hit locally because I'm using gcc 7. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480
Flags: needinfo?(mh+mozilla)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 12•7 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/b744eba9ca78 Simplify the trait users of DoublyLinkedList need to define. r=froydnj https://hg.mozilla.org/integration/autoland/rev/4f17343164b6 Use DoublyLinkedList in mozjemalloc. r=froydnj
Comment 13•7 years ago
|
||
Backed out in https://hg.mozilla.org/integration/autoland/rev/c02d7df64e12 for frequent "Assertion failure: !ElementAccess::Get(mHead).mPrev, at /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/DoublyLinkedList.h:211" like https://treeherder.mozilla.org/logviewer.html#?job_id=129067118&repo=autoland and https://treeherder.mozilla.org/logviewer.html#?job_id=129088002&repo=autoland and https://treeherder.mozilla.org/logviewer.html#?job_id=129103041&repo=autoland, apparently all OS X.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 16•7 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/45c68c943e97 Simplify the trait users of DoublyLinkedList need to define. r=froydnj https://hg.mozilla.org/integration/autoland/rev/c35654690032 Use DoublyLinkedList in mozjemalloc. r=froydnj
Comment 17•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/45c68c943e97 https://hg.mozilla.org/mozilla-central/rev/c35654690032
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•