1396747 - The request's method cannot be deleted in the panel, but it appears deleted in the request lists

Status: RESOLVED WORKSFORME

(DevTools :: Netmonitor, defect, P3)

Description

[Ciprian Georgiu, Desktop QA - PTO, back on Sep 29]

Attachment: screencast showing the issue.gif

[Affected versions]:
- latest Nightly 57.0a1
- Beta 56.0b9
- RC 55.0.3

[Affected platforms]:
- Windows 10 x64
- Mac OS X 10.11.6
- Ubuntu 16.04 x64

[Steps to reproduce]:
1. Start Firefox.
2. Go any webpage e.g.: https://en.wikipedia.org/wiki/Main_Page
3. Open netmonitor.
4. Click on a request from the list in order to open the Details panel.
5. Click on Edit and Resend button from the Headers tab.
6. Try to delete the request's method by pressing backspace.

[Expected result]:
- The request's method can be deleted.

[Actual result]:
- The request's method is not deleted in the panel, but it appears deleted in the request lists.

[Regression range]:
- Last good revision: aa534d18c2d25e96243620532d62321ede91ccb9
  First bad revision: bdc79139892e9417108f2653af5a3fd9c37d1b62
  Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=aa534d18c2d25e96243620532d62321ede91ccb9&tochange=bdc79139892e9417108f2653af5a3fd9c37d1b62

[Additional notes]:
- see the attached screencast

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report I can reproduce the bug on my machine.


Ricky: the problem is that CustomRequestPanel is using hardcoded
values for the method and URL fields:

http://searchfox.org/mozilla-central/rev/67f38de2443e6b613d874fcf4d2cd1f2fc3d5e97/devtools/client/netmonitor/src/components/custom-request-panel.js#92-98

This causes the field to always display something while the request list is showing an empty value.

I think we could remove the hardcoded values and validate the form when the user presses the "send" button.
What do you think?

Honza

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Yes, totally agree.

Both of those default input values ("GET", "http://") [1] should be removed. And then set default values when validating the form at [2].

[1] http://searchfox.org/mozilla-central/rev/67f38de2443e6b613d874fcf4d2cd1f2fc3d5e97/devtools/client/netmonitor/src/components/custom-request-panel.js#92,98
[2] http://searchfox.org/mozilla-central/rev/67f38de2443e6b613d874fcf4d2cd1f2fc3d5e97/devtools/client/netmonitor/src/components/custom-request-panel.js#206,238

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for a fix for 57.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This is bug is no longer reproducible, closing.

Honza