MIPS: Fix MOVF in simulator

RESOLVED FIXED in Firefox 57

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: miran.karic, Assigned: miran.karic)

Tracking

Trunk
mozilla57
Other
All
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.104 Safari/537.36

Steps to reproduce:

When reading cc field for MOVF instruction, incorrect bits were accessed. This caused the test asm.js/testMathLib.js to fail. The uploaded patch fixes the problem with MOVF.
Assignee

Comment 1

2 years ago
Attachment #8904486 - Flags: review?(lhansen)
Attachment #8904486 - Flags: checkin?
Comment on attachment 8904486 [details] [diff] [review]
0001-Bug-1396767-MIPS-Fix-MOVF-in-simulator.patch

Review of attachment 8904486 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable to me, though I haven't looked in detail (not enough of a MIPS expert :)
Attachment #8904486 - Flags: review?(lhansen)
Attachment #8904486 - Flags: review+
Attachment #8904486 - Flags: checkin?
Keywords: checkin-needed
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Unspecified → All
Hardware: Unspecified → Other
Assignee

Comment 3

2 years ago
(In reply to Lars T Hansen [:lth] from comment #2)
> Comment on attachment 8904486 [details] [diff] [review]
> 0001-Bug-1396767-MIPS-Fix-MOVF-in-simulator.patch
> 
> Review of attachment 8904486 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks reasonable to me, though I haven't looked in detail (not enough of a
> MIPS expert :)

Thank you! Could you also assign this to me, not sure but maybe this is needed to land?
I *think* the checkin-needed should be enough but it won't hurt if you own the bug.
Assignee: nobody → miran.karic
https://hg.mozilla.org/mozilla-central/rev/8bc120c1cd33
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.