Closed
Bug 1396776
Opened 7 years ago
Closed 7 years ago
Move mCanvasTM from the derived class of nsSVGViewportFrame to nsSVGViewportFrame
Categories
(Core :: SVG, enhancement)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: u459114, Assigned: u459114)
Details
Attachments
(1 file, 1 obsolete file)
With this change, we do not need to dealloc/allocate memory for mCanvasTM when NotifySVGChanged(nsSVGDisplayableFrame::TRANSFORM_CHANGED)/GetCanvasTM is called. Better for performance.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Summary: Replace the type of nsSVGViewportFrame::mCanvasTM by Maybe<gfxCanvas> → Move mCanvasTM from the derived class of nsSVGViewportFrame to nsSVGViewportFrame
Comment hidden (mozreview-request) |
Attachment #8904483 -
Attachment is obsolete: true
Comment hidden (mozreview-request) |
Attachment #8904484 -
Flags: review?(longsonr)
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8904484 [details] Bug 1396776 - Move mCanvasTM from the sub classes of nsSVGDisplayContainerFrame to nsSVGDisplayContainerFrame. https://reviewboard.mozilla.org/r/176344/#review181418 ::: commit-message-ccbb8:3 (Diff revision 3) > +Bug 1396776 - Move mCanvasTM from the sub classes of nsSVGDisplayContainerFrame to nsSVGDisplayContainerFrame. > + > +All classes which have mCanvasTM decalred as a member object are inherited from declared (not decalred)
Attachment #8904484 -
Flags: review?(longsonr) → review+
Comment hidden (mozreview-request) |
Pushed by cku@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b502be79aeb1 Move mCanvasTM from the sub classes of nsSVGDisplayContainerFrame to nsSVGDisplayContainerFrame. r=longsonr+218550
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b502be79aeb1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•