1396778 - Parser: Support multiline variants

Status: RESOLVED FIXED

(L20n :: Python Library, defect)

Description

[Staś Małolepszy :stas]

Let's unskip these tests:

    @unittest.skip("Parsing error")
    def test_variant_multiline_first_inline(self):
        input = """\
            foo = {
                   *[a] AAA
                        BBB
                }
        """
        self.assertEqual(pretty_ftl(input), dedent_ftl(input))

    @unittest.skip("Parsing error")
    def test_variant_multiline(self):
        input = """\
            foo = {
                   *[a]
                       AAA
                       BBB
                }
        """
        self.assertEqual(pretty_ftl(input), dedent_ftl(input))

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

:stas, it seems to work in the parser. Can you confirm?

Comment 2

[Staś Małolepszy :stas]

Ha, interesting. I only tried unskipping these tests before I submitted this bug, and indeed one of them still fails, but the reason is different.

I did some research. It looks like the parsing bug was fixed along the way when I landed https://github.com/projectfluent/python-fluent/pull/17. The first test still fails today because the Serializer sees a new line between AAA and BBB and decides to format the whole variant as a multi-line block. I filed bug 1397760 to make a decision about this behavior.

The second test fails because the variant is indented by 7 and not 8 spaces. That's an easy fix, and I'll land it without review.

Thanks for looking into this, Zibi!

Comment 3

[Staś Małolepszy :stas]

https://github.com/projectfluent/python-fluent/commit/d1019396cc6cd91aea9971eb0fe16f77eb68045b