Closed
Bug 1396783
Opened 7 years ago
Closed 7 years ago
devtools/client/inspector/inspector.js loads too many dependencies
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
It takes 55ms/15% of JS computing in the parent process. With the upcoming patch it drops down to 4.4ms/1.6%. Profile without the patch: https://perfht.ml/2iYWNDJ Profile with the patch: https://perfht.ml/2eB0Z7w Again, as for bug 1396619, various deps are loaded later, so the win isn't necessary the pure difference that I highlight here. http://searchfox.org/mozilla-central/source/devtools/client/inspector/inspector.js#15-41 Most of this can be lazy loaded and especially the one that aren't used in Inspector constructor, nor init method. There is even value in lazy loading deps only used in deferredOpen. It allows calling Inspector.init sooner and so run necessary action like initCssProperties in the content process sooner/in parallel.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → poirot.alex
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
Waiting for try results before r?: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0bfea7c4f1e7cb60bff4d072679aef65fae3274
Assignee | ||
Comment 3•7 years ago
|
||
Try is green but DAMP again do not report any win whereas it should: https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=07af3090520d8784564b4cc4ad8c1e2ee051ca55&newProject=try&newRevision=b0bfea7c4f1e7cb60bff4d072679aef65fae3274&originalSignature=edaec66500db21d37602c99daa61ac983f21a6ac&newSignature=edaec66500db21d37602c99daa61ac983f21a6ac&filter=inspector&framework=1
Assignee | ||
Updated•7 years ago
|
Attachment #8904496 -
Flags: review?(pbrosset)
Assignee | ||
Comment 4•7 years ago
|
||
New DAMP try including DAMP fixes from bug 1394804: https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=94783d31562766bec9dda8710aaea2b4c79babee&newProject=try&newRevision=512d62a6ef443a09de570060527193baeb8ba740&originalSignature=edaec66500db21d37602c99daa61ac983f21a6ac&newSignature=edaec66500db21d37602c99daa61ac983f21a6ac&framework=1 It report a 5% win for cold start and about nothing on warm start.
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8904496 [details] Bug 1396783 - Lazy load inspector.js dependencies. https://reviewboard.mozilla.org/r/176352/#review182242
Attachment #8904496 -
Flags: review?(pbrosset) → review+
Assignee | ||
Comment 6•7 years ago
|
||
Green try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0bfea7c4f1e7cb60bff4d072679aef65fae3274
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4c75e29bdb1b Lazy load inspector.js dependencies. r=pbro
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4c75e29bdb1b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•