mar_read_product_info_block: Value stored to 'location' is never read

RESOLVED FIXED in Firefox 57

Status

()

Toolkit
Application Update
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: sylvestre, Assigned: Cosm, Mentored)

Tracking

(Blocks: 1 bug, {good-first-bug})

unspecified
mozilla57
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [good first bug][lang=C++])

Attachments

(1 attachment)

788 bytes, patch
rstrong
: review+
sylvestre
: feedback+
Details | Diff | Splinter Review
(Reporter)

Description

2 months ago
http://sylvestre.ledru.info/reports/fx-scan-build/report-mar_read.c-mar_read_product_info_block-65-2.html#EndPath
Value stored to 'location' is never read
the line should probably be removed
(Assignee)

Comment 1

2 months ago
I wan to work on this issue.
(Reporter)

Comment 2

2 months ago
Sure, just submit a patch!
(Assignee)

Comment 3

2 months ago
Created attachment 8904715 [details] [diff] [review]
patchfile
Attachment #8904715 - Flags: review?(sledru)
(Reporter)

Comment 4

2 months ago
Comment on attachment 8904715 [details] [diff] [review]
patchfile

Good, now, you should look for the right reviewer for this!
Attachment #8904715 - Flags: review?(sledru) → feedback+
(Assignee)

Comment 5

2 months ago
Can you suggest someone who has to review this too?
I'll get to it likely within 24 hours
Comment on attachment 8904715 [details] [diff] [review]
patchfile

Thanks! I'll land this
Attachment #8904715 - Flags: review+
Assignee: nobody → kausam2015
Status: NEW → ASSIGNED

Comment 8

2 months ago
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3e93511d037
mar_read_product_info_block: Value stored to 'location' is never read. r=rstrong
https://hg.mozilla.org/mozilla-central/rev/b3e93511d037
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.