Closed Bug 1396795 Opened 3 years ago Closed 3 years ago

mar_read_product_info_block: Value stored to 'location' is never read

Categories

(Toolkit :: Application Update, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: Sylvestre, Assigned: kausam2015, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [good first bug][lang=C++])

Attachments

(1 file)

788 bytes, patch
robert.strong.bugs
: review+
Sylvestre
: feedback+
Details | Diff | Splinter Review
http://sylvestre.ledru.info/reports/fx-scan-build/report-mar_read.c-mar_read_product_info_block-65-2.html#EndPath
Value stored to 'location' is never read
the line should probably be removed
I wan to work on this issue.
Sure, just submit a patch!
Attached patch patchfileSplinter Review
Attachment #8904715 - Flags: review?(sledru)
Comment on attachment 8904715 [details] [diff] [review]
patchfile

Good, now, you should look for the right reviewer for this!
Attachment #8904715 - Flags: review?(sledru) → feedback+
Can you suggest someone who has to review this too?
I'll get to it likely within 24 hours
Comment on attachment 8904715 [details] [diff] [review]
patchfile

Thanks! I'll land this
Attachment #8904715 - Flags: review+
Assignee: nobody → kausam2015
Status: NEW → ASSIGNED
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3e93511d037
mar_read_product_info_block: Value stored to 'location' is never read. r=rstrong
https://hg.mozilla.org/mozilla-central/rev/b3e93511d037
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.