1396806 - 55 attached to a sync account causes any 57 devices attached to mess up the customizableUI layout of 57

Status: RESOLVED DUPLICATE of bug 1373244

(Firefox :: Sync, defect)

Description

[Gurenko Alex]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170904220027

Steps to reproduce:

I've found this bug still unassigned [0] and I'd like to raise this in 57 nightly. With Sync enabled customized layout is not synchronized, however if Firefox stable is opened with same account, nighly's layout is getting messed up with buttons being added according to FF stable layout.

[0] https://bugzilla.mozilla.org/show_bug.cgi?id=761938


Actual results:

2 Nightly instance not in sync


Expected results:

If one of the nightly's layout changes, other nightly connected to same account should adjust accordingly

Comment 1

[Lina Butler [:lina]]

(In reply to Gurenko Alex from comment #0)
> however if
> Firefox stable is opened with same account, nighly's layout is getting
> messed up with buttons being added according to FF stable layout.

Hi! Do you mean switching between stable and Nightly on the same device with the same profile, or do you have two different devices or different profiles?

If the former, I think we already have a (possibly WONTFIX?) bug on file for the layout being off after a profile downgrade. Gijs, does that sound familiar to you?

Comment 2

[Gurenko Alex]

So:
 - my request is that two nightly on different computers with same account should sync layout and right now they don't.
 - BUT. If you launch FF55 elsewhere that uses same account, all NIGHTLY instances on all machine get their layout messed up

Comment 3

[Lina Butler [:lina]]

I see, thanks! That's very helpful. Clearing ni? for Gijs, since it sounds like one of the synced prefs might be causing this.

Just to make sure, you have "Preferences" checked in about:preferences#sync, and haven't added any custom `services.sync.prefs.sync` prefs to about:config, right?

Comment 4

[Gurenko Alex]

(In reply to Kit Cambridge (he/him) [:kitcambridge] (UTC-7) from comment #3)
> I see, thanks! That's very helpful. Clearing ni? for Gijs, since it sounds
> like one of the synced prefs might be causing this.
> 
> Just to make sure, you have "Preferences" checked in about:preferences#sync,
> and haven't added any custom `services.sync.prefs.sync` prefs to
> about:config, right?

Yes, preferences are set to enable in sync and I didn't touch about:config :)

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Updating the title to reflect what I think this bug is saying. We should dig into this and see if we can repro.

Comment 6

[Gurenko Alex]

(In reply to Mark Hammond [:markh] from comment #5)
> Updating the title to reflect what I think this bug is saying. We should dig
> into this and see if we can repro.

Well, that's 1 of the problem here; I don't understand right now whether layout should sync between 2 FF57 instances?

Comment 7

[Mark Hammond [:markh] [:mhammond]]

(In reply to Gurenko Alex from comment #6)
> Well, that's 1 of the problem here; I don't understand right now whether
> layout should sync between 2 FF57 instances?

We don't sync that state between devices currently, but that's already tracked as bug 
761938 which you found, and also 943182 - so I've basically tweaked this bug to only track this new issue that isn't covered elsewhere.

Comment 8

[Gurenko Alex]

(In reply to Mark Hammond [:markh] from comment #7)
> (In reply to Gurenko Alex from comment #6)
> > Well, that's 1 of the problem here; I don't understand right now whether
> > layout should sync between 2 FF57 instances?
> 
> We don't sync that state between devices currently, but that's already
> tracked as bug 
> 761938 which you found, and also 943182 - so I've basically tweaked this bug
> to only track this new issue that isn't covered elsewhere.

Got it, yes, so then this title reflect remaining issue correctly.

Comment 9

[Mark Hammond [:markh] [:mhammond]]

I'm afraid I can't reproduce this issue. What I did was to create a new profile with Firefox 55, then performed some customizations in 55 (eg, moved a number of buttons into the toolbar), then connected to an existing Sync account and let that complete. The toolbar then changed a little as addons from the sync account came in, but these were all new buttons - none of the existing placements changed.

I then quit that profile and opened an existing profile with 57. I performed some additional customizations there and let Sync complete. Nothing changed. I quit that profile, and reopened the new profile using 55 and synced - again, no customization changes. I tried swapping back and forward a few times but couldn't demonstrate a problem.

One thing we discussed is that over the last few weeks there have been a number of tweaks to 57, some of which caused customizations to be lost on upgrade. Obviously this isn't going to happen as 57 moves to beta - it's just a "feature" of living on the bleeding-edge that is nightly :) Is it possible you struck something like this, but chalked it up to Sync?

If not, could you please try again to reproduce it and give detailed instructions of the steps you went through and exactly what you saw happen?

Thanks!

Comment 10

[Gurenko Alex]

Attachment: initial.png

This is the initial layout I have. I've customized it and synced it

Comment 11

[Gurenko Alex]

Attachment: after.png

This is how same FF57 instance look if I open FF55 in between

Comment 12

[Gurenko Alex]

I've recorded the process, but it seems very straight forward to me. (Sorry for a mess in a video, I'm install FF55 just to recorded, I'm only using nightly as day-to-day driver right now)

Basically the process is following:

 - Open FF57, customize toolbar, sync to the account, close FF57
 - Open FF55, do absolutely nothing (except let the sync run), close it
 - Open FF57 again

Result: toolbar layout changes

Expected result: toolbar should be exactly the same as before opening FF55

I hope that clarify things

https://drive.google.com/file/d/0B2AV4x0AVtwtMTlmUkZ6TlA1Qlk/view?usp=sharing

Comment 13

[Mark Hammond [:markh] [:mhammond]]

I don't quite understand the "after" picture - it looks like some profile just upgraded to 57 rather than an existing 57 being reopened. Sadly the video you uploaded has many artifacts and my local vlc doesn't play it very clearly.

Also, re "Open FF55, do absolutely nothing (except let the sync run), close it" - that will not actually sync anything as nothing will have changed.

Comment 14

[Gurenko Alex]

(In reply to Mark Hammond [:markh] from comment #13)
> I don't quite understand the "after" picture - it looks like some profile
> just upgraded to 57 rather than an existing 57 being reopened.

It's a same profile, I also get this message every time after I open F55.

> Sadly the
> video you uploaded has many artifacts and my local vlc doesn't play it very
> clearly.

I've made another one with H.264 encoding instead of VP8, I hope that's better. Both plays fine on my machine, so maybe try other player?

> 
> Also, re "Open FF55, do absolutely nothing (except let the sync run), close
> it" - that will not actually sync anything as nothing will have changed.

So it must be some configuration they two share and overwrites them? I can't tell you the answer, I can only guess and send you the results...

Link to new video: https://drive.google.com/open?id=0B2AV4x0AVtwtU0o3UUJoT1ltcEE

Comment 15

[Mark Hammond [:markh] [:mhammond]]

(In reply to Gurenko Alex from comment #14)
> (In reply to Mark Hammond [:markh] from comment #13)
> > I don't quite understand the "after" picture - it looks like some profile
> > just upgraded to 57 rather than an existing 57 being reopened.
> 
> It's a same profile, I also get this message every time after I open F55.

Are you sure you aren't sharing the same profile between 55 and 57? That would explain both this symptom and the other symptoms you describe.

Comment 16

[Gurenko Alex]

(In reply to Mark Hammond [:markh] from comment #15)
> (In reply to Gurenko Alex from comment #14)
> > (In reply to Mark Hammond [:markh] from comment #13)
> > > I don't quite understand the "after" picture - it looks like some profile
> > > just upgraded to 57 rather than an existing 57 being reopened.
> > 
> > It's a same profile, I also get this message every time after I open F55.
> 
> Are you sure you aren't sharing the same profile between 55 and 57? That
> would explain both this symptom and the other symptoms you describe.

 Yeah, looks like that's it... I saw two profiles {uid}.default and I assumed they were for stable and nightly respectively, but turned out it's not the case. So, since that's the case, shouldn't nightly store profiles probably locally for example?

Comment 17

[Mark Hammond [:markh] [:mhammond]]

Yeah, it should - that's bug 1373244. Should I close this as a dupe of that?

Comment 18

[Gurenko Alex]

(In reply to Mark Hammond [:markh] from comment #17)
> Yeah, it should - that's bug 1373244. Should I close this as a dupe of that?

Yes, go ahead, thank you

Comment 19

[:Gijs (he/him)]

Closing out per the last few comments. Sorry about how confusing our current setup is, and thanks for all the digging and responses!