1396820 - warning: variant is never used: `Quit`

Status: RESOLVED WONTFIX

(Testing :: geckodriver, enhancement, P3)

Description

[Andreas Tolfsen ❲:ato❳]

whimboo writes in https://github.com/mozilla/webdriver-rust/issues/112:

> This seems to have been introduced lately and which is causing a compiler > warning:
> 
> warning: variant is never used: Quit
> --> src/server.rs:23:5
> |
> 23 | Quit
> | ^^^^
> |
> = note: #[warn(dead_code)] on by default
> 
> The Ok case is already handled in line 63, so we never reach line 88:
> https://github.com/mozilla/webdriver-rust/blob/master/src/server.rs#L63-L88

Comment 1

[Andreas Tolfsen ❲:ato❳]

jgraham:

> This is a longstanding warning. It will probably go away if we
> implement signal handling using the chan-signal crate.

Comment 2

[Andreas Tolfsen ❲:ato❳]

whimboo:

> Interesting because AFAIR I haven't seen it when compiling
> geckodriver lately with webdriver-rust 0.27. Maybe I don't
> remember correctly.

Comment 3

[Andreas Tolfsen ❲:ato❳]

whimboo:

> Ok, so this indeed goes back way longer. Thanks for mentioning
> this James.

Comment 4

[Andreas Tolfsen ❲:ato❳]

Oops, I didn’t mean to assign myself to this.

Comment 5

[David Burns :automatedtester]

Attachment: Bug 1396820: Remove unused variant Quit in webdriver

Review commit: https://reviewboard.mozilla.org/r/250794/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250794/

Comment 6

[James Graham [:jgraham]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1430064 will make this used. We didn't finish that pending Windows support in chan_signal. If that hasn't happened yet we might want to revisit that issue with a different approach for the signal handling, but I expect any approach we take is going to dispatch a quit message (and when we upgrade hyper it might even work properly :)

I suggest we WONTFIX this issue in the interim.

Comment 7

[David Burns :automatedtester]

Closing as suggested.

Comment 8

[James Graham [:jgraham]]

Comment on attachment 8985077 [details]
Bug 1396820: Remove unused variant Quit in webdriver

https://reviewboard.mozilla.org/r/250794/#review257244