1396833 - Tabs can overlap

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Andrew Halberstadt [:ahal]]

https://i.imgur.com/QCI1EIt.png

Restarting the browser fixed the issue. Note the overlapping tabs on the left and the gap on the right (presumably the same width as the overlapped portion). The close button on that newtab page is also un-clickable (though ctrl-w works). Otherwise switching, closing and other tab operations seem to work normally.

Wish I could provide more details, but I can't reproduce and have no idea how I got into this state.

Comment 1

[Andrew Halberstadt [:ahal]]

Forgot to mention, this was before updating to todays nightly and I have stylo enabled.

Comment 3

[Justin Dolske [:Dolske]]

Dao -- what do you want to do here? Is there something we can investigate (especially since there seem to be a few related bugs), or is this non-reproducible / inactionable?

Comment 4

[Dão Gottwald [:dao]]

I've never seen this myself and we have no steps to reproduce.

Comment 5

[Andrew Halberstadt [:ahal]]

Fwiw, I haven't seen this since either.

Comment 6

[Andrew Halberstadt [:ahal]]

I hit this again. It happened when tabs overflowed the tab bar, and persisted even after closing + re-opening them. Restarting Firefox fixed the issue again.

Comment 7

[Andrew Halberstadt [:ahal]]

Oh yeah, and any tabs after the overlapping tabs can't be closed by clicking the 'x'. My theory is that Firefox still thinks they are in their normal positions but they just aren't being drawn properly.

Comment 10

[Mark Banner (:standard8)]

As per bug 1406370, I've seen this occasionally. I've also seen slightly more recently that the chrome UI part of FF seems to lock up completely and won't re-render. Restarting fixes it.

There's nothing mentioned on the browser console either.

Comment 11

[Mike Taylor [:miketaylr]]

Looking through all the dupes/see alsos, seems like this bug is tricky to reliably hit. :|

Comment 12

[Ted Campbell [:tcampbell]]

(In reply to Andrew Halberstadt [:ahal] from comment #7)
> Oh yeah, and any tabs after the overlapping tabs can't be closed by clicking
> the 'x'. My theory is that Firefox still thinks they are in their normal
> positions but they just aren't being drawn properly.

When I hit this, the X doesn't work for the current active tab (even if I switch to one that isn't moved around). The X *does* work for closing background tab, even if they are shifted around in the wrong position.

Comment 13

[Mark Banner (:standard8)]

Report from the support site:

https://support.mozilla.org/en-US/questions/1184823

Comment 14

[Ted Campbell [:tcampbell]]

Another observation I had was that the mouse-over effect wasn't working for the current tab. I believe the rendering is fine and the js/xbl for the tabbar is wrong. It seems like close state was was toggled due to some animation/drag/overflow and we lost an event and never undid the state.

Unfortunately the browser debugger refused to start so I could not look at any data.

Comment 15

[Blake Winton (:bwinton) (:☕️)]

My wife has hit this (on macOS) a couple of times since upgrading.
I got a Browser Toolbox Inspector screenshot of it at https://www.dropbox.com/s/mlrxyvb9y9wp931/TabOddities.png?dl=0 which might be of some help? (At least it tells us that the first non-pinned tab has a wildly incorrect `translate: transformX` value.)

If there are other things you'd like me to poke into the next time it happens, I'm more than happy to help.

Comment 16

[Tim Taubert [:ttaubert] (inactive)]

I'm currently able to reliably reproduce this. I need a certain number of tabs, open a new one and drag&drop it quickly to the very right, before it's loaded. In the console I see this:

ASSERT: Giving up waiting for the tab closing animation to finish (bug 608589)
	NS_ASSERT resource://gre/modules/debug.js:53:3
	removeTab/< chrome://browser/content/tabbrowser.xml:3157:17

Comment 17

[Tim Taubert [:ttaubert] (inactive)]

After dropping the tab, it's still "floating", the tabbar still has [movingtab=true]. I assume that somehow _finishAnimateTabMove() isn't called when it should be.

Comment 18

[Tim Taubert [:ttaubert] (inactive)]

Removing the "floating" tab is what breaks the UI then, not surprisingly.

I can see that <handler event="drop"> is called and we enter the following branch:

https://searchfox.org/mozilla-central/rev/c633ffa4c4611f202ca11270dcddb7b29edddff8/browser/base/content/tabbrowser.xml#7601

That transition probably doesn't end. I'll check the translateX values to see what's up here.

Comment 19

[Tim Taubert [:ttaubert] (inactive)]

oldTranslateX=1259.1000061035156 and newTranslateX=1259.0999450683594. I'm not sure what the rules around sub-pixel transforms are... but it seems like in this case that's too close together and we just do nothing.

Comment 20

[Tim Taubert [:ttaubert] (inactive)]

Submitted a patch that fixes the issue for me. I found only mconley on Phabricator, but I'll take reviews from any other browser peer ;)

https://phabricator.services.mozilla.com/D265

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9227aaffbe7
Fix tab drag&drop not finishing due to CSS transform not kicking in r=mconley

Comment 22

[Dão Gottwald [:dao]]

Thanks Tim.

We'll want to uplift this to Beta.

Comment 23

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e9227aaffbe7

Comment 24

[Dão Gottwald [:dao]]

Comment on attachment 8930159 [details]
Bug 1396833 - Fix tab drag&drop not finishing due to CSS transform not kicking in

Approval Request Comment
[Feature/Bug causing the regression]: bug 1355507
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: see comment 16, although this probably isn't reproducible everywhere. Might be DPI dependent.
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial fix
[String changes made/needed]: /

Comment 25

[Gerry Chang [:gchang]]

Comment on attachment 8930159 [details]
Bug 1396833 - Fix tab drag&drop not finishing due to CSS transform not kicking in

Fix an overlapped tabs issue. Beta58+.

Comment 26

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/33e95d96edd2

Comment 28

[Alexandru Simonca [:asimonca], Release Desktop QA]

This is VERIFIED FIXED in 58 beta 12 and the latest Nightly. Can not reproduce anymore. Marking it as fixed.

Comment 29

[Phabricator Automation]

Comment on attachment 8930159 [details]
Bug 1396833 - Fix tab drag&drop not finishing due to CSS transform not kicking in

Mike Conley (:mconley) (:⚙️) - Backlogged on reviews and needinfos has approved the revision.

https://phabricator.services.mozilla.com/D265#6517