Closed Bug 1396836 Opened 2 years ago Closed 2 years ago

"no search results" shown for about:telemetry "raw payload" section

Categories

(Toolkit :: Telemetry, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: gfritzsche, Assigned: chutten|PTO)

References

Details

Attachments

(2 files)

- select any custom ping ("bhr", "health", etc.)
- go to the "raw payload" section

Result: both the raw payload JSON as well as the "sorry, no search results" message are shown (see attached screenshot).

Expected: no "sorry, no search results message".
Assignee: nobody → chutten
Priority: P2 → P1
Comment on attachment 8906080 [details]
bug 1396836 - Tidy up about:telemetry search

https://reviewboard.mozilla.org/r/177814/#review183204

::: toolkit/content/aboutTelemetry.js:1378
(Diff revision 1)
>      let section = sectionParam;
>      if (!section) {
>        let sectionId = document.querySelector(".category.selected").getAttribute("value");
>        section = document.getElementById(sectionId);
>      }
> +    if (Search.blacklist.includes(section.id)) {

Not stricly related to this patch, but would you mind adding a comment where "blacklist" is defined to explain what it is for?
Attachment #8906080 - Flags: review?(alessio.placitelli) → review+
I'll do that the next time I'm in the file. FWIW, it's a list of ids for sections that don't support search.
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6ec5f35710a
Tidy up about:telemetry search r=Dexter
Backed out for eslint failures in aboutTelemetry.js:

https://hg.mozilla.org/integration/autoland/rev/3be0f512422bcf03178c3c1160328d2e6e7ca678

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c6ec5f35710a1f0db8609c36d158c28f9add842f&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=130083781&repo=autoland

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/content/aboutTelemetry.js:1383:7 | Method 'search' expected no return value. (consistent-return)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/content/aboutTelemetry.js:1424:5 | Method 'search' expected no return value. (consistent-return)
Flags: needinfo?(chutten)
Apparently I'll get to that comment in this revision after all...

The failure is that search() returns a value (mostly unused, but still) but I introduced an empty early return without specifically returning false (meaning that there isn't no search results (double negative sadly necessary)). I'll add the false and the comment and get this back in, likely tomorrow given my meeting load today.
Flags: needinfo?(chutten)
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e19a2e8394e8
Tidy up about:telemetry search r=Dexter
https://hg.mozilla.org/mozilla-central/rev/e19a2e8394e8
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.