don't allow system addon superblobs to reference non-existent releases

RESOLVED WONTFIX

Status

Release Engineering
Balrog: Backend
P3
normal
RESOLVED WONTFIX
8 months ago
4 months ago

People

(Reporter: bhearsum, Assigned: Mercy Muchai)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=python][ready])

(Reporter)

Description

8 months ago
Today I noticed that we have a SystemAddon blob that references some non-existent releases. The blob in question looks like this:
{
  "blobs": [
    "e10srollout@mozilla.org-2.05",
    "followonsearch@mozilla.com-0.9.3",
    "screenshots@mozilla.org-10.12.0"
  ],
  "name": "SystemAddons-e10srollout-2.05-followonsearch-0.9.3-screenshots-10.12.0-Superblob",
  "schema_version": 4000
}

...but none of the referenced blobs exist.

We should override .validate() in https://github.com/mozilla/balrog/blob/master/auslib/blobs/systemaddons.py to ensure this can't be the case.

Comment 1

7 months ago
I'm a student at Seneca college learning open source, and I was hoping to work on this bug for my course.  If no one else is currently working on it, I'd like to give it a try.

Updated

7 months ago
Assignee: nobody → mercy.muchai
(Assignee)

Comment 2

6 months ago
How can I replicate this bug?
Flags: needinfo?(bhearsum)
(Reporter)

Comment 3

6 months ago
(In reply to Mercy Muchai from comment #2)
> How can I replicate this bug?

Try uploading a Release with the following contents:
{
    "blobs": ["missing"],
    "name": "Superblob-With-Missing-Blob",
    "schema_version": 4000
}


Currently, Balrog accepts this Release, even though there's no release in the system called "missing". This shouldn't happen - the backend should raise an error when "blobs" contains a release name that doesn't exist.
Flags: needinfo?(bhearsum)
(Reporter)

Updated

5 months ago
Priority: P1 → P3
(Reporter)

Comment 4

4 months ago
Hi Mercy,

We recently made the decision to move SystemAddons out of Balrog - this bug is no longer worth fixing, so I'm going close it. I appreciate any effort you already spent here, sorry it wasn't able to be completed.
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.