Closed
Bug 1396860
Opened 8 years ago
Closed 8 years ago
Add ability to specify a rebuild count on try with 'try_task_config.json'
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1414919
People
(Reporter: impossibus, Unassigned)
Details
+++ This bug was initially created as a clone of Bug #1387135 +++
This helps automation like web-platform-tests sync to step away from generating try syntax. (e.g. right now the project automating web-platform-tests sync expects to use the --rebuild try syntax option to check stability when importing upstream tests.)
In the future, this can also enable removing the --rebuild option from general developer-facing tools like try syntax or mach try, in favour of forcing humans to request rebuilds in the Treeherder UI, for example. If someone (or some tool) really wants to rebuild 20 times, they could do so only by providing a try-task-config.json.
Comment 1•8 years ago
|
||
++ I like it!
The "rebuilding" is currently done at the last second, in taskcluster/taskgraph/generate.py. Extending that to support getting information from params['try_task_config'], if set, wouldn't be too hard.
Ideally this would be flexible enough to support things like "run most tasks once but THIS task 20 times", which --rebuild and --rebuild-talos don't support.
Comment 2•8 years ago
|
||
Do you want to have web-platform-tests sync shell out to |mach try fuzzy -q "'web-platform"| (or similar), or were you planning to manually generate and push try_task_config.json?
If you wanted to do the former, we could just add a --rebuild option to |mach try fuzzy| and worry about excluding specific tasks later (I think the UX for that will be tricky). If you wanted to do the latter, we could land the support for this in taskgraph and worry about |mach try fuzzy| later. (Also if you do the latter, I highly recommend using tools/tryselect/vcs.py to do the try_task_config.json generation + pushing)
| Reporter | ||
Comment 3•8 years ago
|
||
I was thinking of generating and pushing try_task_config.json.
| Reporter | ||
Comment 4•8 years ago
|
||
Looks like this got fixed in Bug 1414919
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Updated•8 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•