Closed
Bug 1396862
Opened 7 years ago
Closed 7 years ago
eliminate -Wunused-private-field warning in AutoFlushICache
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
2.05 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
The `name_` field of AutoFlushICache is only ever passed to JitSpew* on ARM, and on non-debug builds, JitSpew* essentially disappears, so clang claims `name_` is unused. It is annoying to jump through hoops to satisfy clang here, but that's life with fatal warnings.
Assignee | ||
Comment 1•7 years ago
|
||
This patch fixes the problem with clang; I expect that it will still work with GCC, but haven't tested it yet.
Attachment #8904585 -
Flags: review?(jdemooij)
Comment 2•7 years ago
|
||
Comment on attachment 8904585 [details] [diff] [review] eliminate -Wunused-private-field warning in AutoFlushICache Review of attachment 8904585 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8904585 -
Flags: review?(jdemooij) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7e1396b4b627 eliminate -Wunused-private-field warning in AutoFlushICache; r=jandem
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7e1396b4b627
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•