Closed Bug 1396863 Opened 7 years ago Closed 7 years ago

eliminate -Wignored-qualifiers warning in EventDispatcher

Categories

(Core Graveyard :: Widget: Android, enhancement)

enhancement
Not set
normal

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

clang complains about the unnecessary `const` here, which we can remove.
clang complains thusly:

In file included from /builds/worker/workspace/build/src/obj-firefox/widget/android/Unified_cpp_widget_android0.cpp:20:
In file included from /builds/worker/workspace/build/src/widget/android/AndroidBridge.cpp:23:
In file included from /builds/worker/workspace/build/src/widget/android/nsWindow.h:15:
/builds/worker/workspace/build/src/widget/android/EventDispatcher.h:56:33: error: 'const' qualifier on reference type 'jni::Object::Param' (aka 'const Ref<mozilla::jni::Object, _jobject *> &') has no effect [-Werror,-Wignored-qualifiers]
                                 const jni::Object::Param aData,
                                 ^~~~~~
Attachment #8904586 - Flags: review?(nchen)
Blocks: 1163171
Attachment #8904586 - Flags: review?(nchen) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/162f24aa2603
eliminate -Wignored-qualifiers warning in EventDispatcher; r=darchons
https://hg.mozilla.org/mozilla-central/rev/162f24aa2603
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.