Closed Bug 1396869 Opened 7 years ago Closed 7 years ago

eliminate -Wunused-private-field warnings in Android's message pump

Categories

(Core :: IPC, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

Android's MessagePumpForUI includes some useless code in its
MessagePumpAndroid class, which is completely unused.  Let's go ahead
and delete that.
Deleting unused code feels so good.
Attachment #8904590 - Flags: review?(jld)
Blocks: 1163171
Comment on attachment 8904590 [details] [diff] [review]
eliminate -Wunused-private-field warnings in Android's message pump

Review of attachment 8904590 [details] [diff] [review]:
-----------------------------------------------------------------

Yay, less code.  rs=me.
Comment on attachment 8904590 [details] [diff] [review]
eliminate -Wunused-private-field warnings in Android's message pump

r+ for comment 2.
Attachment #8904590 - Flags: review?(jld) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/366b9e432a30
eliminate -Wunused-private-field warnings in Android's message pump; r=jld
https://hg.mozilla.org/mozilla-central/rev/366b9e432a30
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.